Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1245703002: Add debug symbols to all generated .isolate. (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 3 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, chromoting-reviews_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, peter+watch_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, Matt Giuca, jdduke+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, erikwright+watch_chromium.org, tapted, mlamouri+watch-notifications_chromium.org, media-router+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, Ian Vollick, tfarina, Aaron Boodman, danakj+watch_chromium.org, Ken Russell (switch to Gerrit), Dirk Pranke, Nico
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2_process
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add debug symbols to all generated .isolate. This will increase the amount of data being uploaded by a ~2x factor or so. Debug symbols are usually larger than the executable itself on pretty much all toolsets but generally have the advantage of being highly compressible. The increase of data not a problem anymore with isolate-go. There will be a small increase of latency but it should be bearable, especially by the gain of enabling stack traces to work for isolated tests on Swarming. R=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8125ce3c695e6d8c02f3b51b16d49e17e7934bb4 Cr-Commit-Position: refs/heads/master@{#349231}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -38 lines) Patch
M tools/isolate_driver.py View 4 chunks +95 lines, -38 lines 0 comments Download

Messages

Total messages: 35 (26 generated)
M-A Ruel
It works. It did increase the amount of data uploaded on Windows, from ~2Gb to ...
5 years, 3 months ago (2015-09-15 19:30:18 UTC) #22
jam
rubberstamp lgtm great!
5 years, 3 months ago (2015-09-16 20:06:47 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245703002/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245703002/420001
5 years, 3 months ago (2015-09-16 20:08:50 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/113954)
5 years, 3 months ago (2015-09-16 20:25:03 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245703002/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245703002/420001
5 years, 3 months ago (2015-09-16 20:31:57 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:420001)
5 years, 3 months ago (2015-09-16 21:05:59 UTC) #31
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8125ce3c695e6d8c02f3b51b16d49e17e7934bb4 Cr-Commit-Position: refs/heads/master@{#349231}
5 years, 3 months ago (2015-09-16 21:06:36 UTC) #32
Ken Russell (switch to Gerrit)
Thanks for pushing this forward!
5 years, 3 months ago (2015-09-16 21:23:42 UTC) #34
Nico
5 years, 3 months ago (2015-09-17 03:16:07 UTC) #35
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:420001) has been created in
https://codereview.chromium.org/1354523002/ by thakis@chromium.org.

The reason for reverting is: Speculative, possibly caused "dyld: Library not
loaded: @rpath/libchrome_main_dll.dylib" test failures in
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29....

Powered by Google App Engine
This is Rietveld 408576698