Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1245663004: [NaCl SDK] Re-land "Added support for NaCl IO to use the IRT Extension API." (Closed)

Created:
5 years, 5 months ago by Sam Clegg
Modified:
5 years, 5 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Re-land "Added support for NaCl IO to use the IRT Extension API." This change was initially landed at 3183230a and then reverted at 8c7a8d9a. In order to better integrate the IRT Extension API into NaCl IO, the first implementation mirrors the other kernel_wrap_* files. All the unit tests should therefore still be valid. Eventually it may be easier to just have a separate version of kernel_intercept which utilizes the IRT extension API directly. Currently the IRT Extension interface is only used for the new arm glibc toolchain, for which there is no other existing method of interception. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG= https://code.google.com/p/nativeclient/issues/detail?id=3918 TEST= trybots Committed: https://crrev.com/f1de4a508142337557ff1751bc83c9f6866f1e1f Cr-Commit-Position: refs/heads/master@{#339574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -12 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap.h View 1 chunk +6 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc View 1 chunk +3 lines, -7 lines 0 comments Download
A native_client_sdk/src/libraries/nacl_io/kernel_wrap_irt_ext.c View 1 chunk +496 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Sam Clegg
5 years, 5 months ago (2015-07-20 21:41:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245663004/1
5 years, 5 months ago (2015-07-20 21:41:55 UTC) #4
binji
lgtm
5 years, 5 months ago (2015-07-20 22:04:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245663004/1
5 years, 5 months ago (2015-07-20 23:55:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 00:28:55 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 00:30:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1de4a508142337557ff1751bc83c9f6866f1e1f
Cr-Commit-Position: refs/heads/master@{#339574}

Powered by Google App Engine
This is Rietveld 408576698