Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1243823002: [NaCl SDK] Second phase of enable glibc arm toolchain (Closed)

Created:
5 years, 5 months ago by Sam Clegg
Modified:
5 years, 5 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@reenable_irtext
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Second phase of enable glibc arm toolchain All libraries and example now build with the ARM glibc toolchain. No tests are run yet. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG=505885 Committed: https://crrev.com/39049e34952eb865eb435415b6537eeb65b8c445 Cr-Commit-Position: refs/heads/master@{#339784}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -65 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +0 lines, -3 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 2 chunks +41 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap.h View 1 chunk +10 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +1 line, -0 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/rpc/netdb.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/accept.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/bind.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/connect.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/gai_strerror.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/getnameinfo.c View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/getpeername.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/getsockname.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/getsockopt.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/listen.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/recv.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/recvfrom.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/recvmsg.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/send.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/sendmsg.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/sendto.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/setsockopt.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/shutdown.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/socket.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/socket/socketpair.c View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfgetispeed.c View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfgetospeed.c View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfsetispeed.c View 2 chunks +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfsetospeed.c View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/termios/cfsetspeed.c View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 2 chunks +6 lines, -0 lines 0 comments Download
M native_client_sdk/src/tools/lib/get_shared_deps.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 4 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243823002/1
5 years, 5 months ago (2015-07-20 23:54:24 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/30016)
5 years, 5 months ago (2015-07-21 00:45:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243823002/20001
5 years, 5 months ago (2015-07-21 01:23:45 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_nacl_sdk on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_nacl_sdk/builds/590)
5 years, 5 months ago (2015-07-21 02:39:21 UTC) #8
Sam Clegg
5 years, 5 months ago (2015-07-21 16:49:38 UTC) #10
binji
lgtm % trybots
5 years, 5 months ago (2015-07-21 17:08:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243823002/20001
5 years, 5 months ago (2015-07-21 20:57:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 23:50:01 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 23:51:06 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39049e34952eb865eb435415b6537eeb65b8c445
Cr-Commit-Position: refs/heads/master@{#339784}

Powered by Google App Engine
This is Rietveld 408576698