Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: test/benchmarks/testcfg.py

Issue 1245623005: [test] Key variant flags by variant name everywhere. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/preparser/testcfg.py » ('j') | test/preparser/testcfg.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/benchmarks/testcfg.py
diff --git a/test/benchmarks/testcfg.py b/test/benchmarks/testcfg.py
index 2a65037754e862369ff537cbcc41c94876ccf321..d4462746a66ba2237c72ce3ce7652e26b05e8df4 100644
--- a/test/benchmarks/testcfg.py
+++ b/test/benchmarks/testcfg.py
@@ -35,6 +35,14 @@ from testrunner.local import testsuite
from testrunner.objects import testcase
+class BenchmarksVariantFlagsBuilder(testsuite.VariantFlagsBuilder):
+ def AllVariants(self, testcase):
+ # Both --nocrankshaft and --stressopt are very slow. Add TF but without
+ # always opt to match the way the benchmarks are run for performance
+ # testing.
+ return self.FastVariants(testcase)
+
+
class BenchmarksTestSuite(testsuite.TestSuite):
def __init__(self, name, root):
@@ -182,11 +190,8 @@ class BenchmarksTestSuite(testsuite.TestSuite):
os.chdir(old_cwd)
- def VariantFlags(self, testcase, default_flags):
- # Both --nocrankshaft and --stressopt are very slow. Add TF but without
- # always opt to match the way the benchmarks are run for performance
- # testing.
- return [[], ["--turbo"]]
Michael Achenbach 2015/07/27 12:37:45 This completely ignored the status file. The new a
+ def VariantFlagsBuilder(self):
+ return BenchmarksVariantFlagsBuilder
def GetSuite(name, root):
« no previous file with comments | « no previous file | test/preparser/testcfg.py » ('j') | test/preparser/testcfg.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698