test/preparser/testcfg.py - Issue 1245623005: [test] Key variant flags by variant name everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/preparser/testcfg.py

Issue 1245623005: [test] Key variant flags by variant name everywhere. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/preparser/testcfg.py

diff --git a/test/preparser/testcfg.py b/test/preparser/testcfg.py

index ddd311c20162e4822a15d8d6d4e256139c2fbd08..bf32a3bb16ddf37932beec2d2bb7f953e995342a 100644

--- a/test/preparser/testcfg.py

+++ b/test/preparser/testcfg.py

@@ -126,8 +126,8 @@ class PreparserTestSuite(testsuite.TestSuite):

with open(testcase.flags[0]) as f:

return f.read()

- def VariantFlags(self, testcase, default_flags):

- return [[]];

+ def VariantFlags(self, variant_filter):

+ return lambda _: testsuite.DEFAULT_VARIANT

Michael Achenbach 2015/07/27 12:37:45 Here, status file filtering is ignored as it doesn

def GetSuite(name, root):