Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1245603003: Add function literal variable to declaration list. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-super-6
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add function literal variable to declaration list. This adds the implicit function variable for a function literal to the declarations list in scope analysis, instead of specially handling it throughout all back-ends. R=rossberg@chromium.org Committed: https://crrev.com/ce6d2241bcf4647315337b60f98dee3b07ac82bd Cr-Commit-Position: refs/heads/master@{#29754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -89 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/scopes.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/typing.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-20 13:35:05 UTC) #1
rossberg
lgtm
5 years, 5 months ago (2015-07-20 14:09:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245603003/1
5 years, 5 months ago (2015-07-20 14:13:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 14:15:07 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 14:15:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce6d2241bcf4647315337b60f98dee3b07ac82bd
Cr-Commit-Position: refs/heads/master@{#29754}

Powered by Google App Engine
This is Rietveld 408576698