[turbofan] Support handling of default super calls.

[turbofan] Support handling of default super calls.

This implements the missing %DefaultConstructorCallSuper runtime
functionality, thereby allowing all compilers to fall-back to that
implementation when the appropriate intrinsic is missing.

R=rossberg@chromium.org

Committed: https://crrev.com/37c2094e8c956e4ef816e7de1a2da9db78e5623d
Cr-Commit-Position: refs/heads/master@{#29753}

[Michael Starzinger, 2015-07-17 13:42:52]

mstarzinger@chromium.org changed reviewers:
+ adamk@chromium.org

[Michael Starzinger, 2015-07-17 13:42:53]

Andreas: PTAL.
Adam: FYI.

[adamk, 2015-07-17 20:04:01]

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes...
src/runtime/runtime-classes.cc:558: RUNTIME_ASSERT(reflect->IsJSFunction());  //
Depends on --harmony-reflect.
--harmony-reflect isn't shipping soon, I think you'll be happier if you just
modify bootstrapper.cc to always put $reflectConstruct on the builtins.

[Michael Starzinger, 2015-07-20 09:03:57]

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes...
src/runtime/runtime-classes.cc:558: RUNTIME_ASSERT(reflect->IsJSFunction());  //
Depends on --harmony-reflect.
On 2015/07/17 20:04:01, adamk wrote:
> --harmony-reflect isn't shipping soon, I think you'll be happier if you just
> modify bootstrapper.cc to always put $reflectConstruct on the builtins.

I think I am confused about what is shipping and what isn't. How can
Parser::SpreadCall desugar to %ReflectConstruct? Aren't classes with super calls
as well as spread calls shipping?

[Michael Starzinger, 2015-07-20 09:14:39]

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes...
src/runtime/runtime-classes.cc:558: RUNTIME_ASSERT(reflect->IsJSFunction());  //
Depends on --harmony-reflect.
On 2015/07/20 09:03:56, Michael Starzinger wrote:
> On 2015/07/17 20:04:01, adamk wrote:
> > --harmony-reflect isn't shipping soon, I think you'll be happier if you just
> > modify bootstrapper.cc to always put $reflectConstruct on the builtins.
> 
> I think I am confused about what is shipping and what isn't. How can
> Parser::SpreadCall desugar to %ReflectConstruct? Aren't classes with super
calls
> as well as spread calls shipping?

Oh boy, in Genesis::InitializeGlobal_harmony_reflect we already explicitly check
for FLAG_harmony_spreadcalls as well. How about we just remove this hack there
and just always install $reflectApply and $reflectConstruct instead?

[Michael Starzinger, 2015-07-20 09:42:38]

Comments addressed. PTAL.

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):

https://codereview.chromium.org/1240993002/diff/1/src/runtime/runtime-classes...
src/runtime/runtime-classes.cc:558: RUNTIME_ASSERT(reflect->IsJSFunction());  //
Depends on --harmony-reflect.
On 2015/07/20 09:14:39, Michael Starzinger wrote:
> On 2015/07/20 09:03:56, Michael Starzinger wrote:
> > On 2015/07/17 20:04:01, adamk wrote:
> > > --harmony-reflect isn't shipping soon, I think you'll be happier if you
just
> > > modify bootstrapper.cc to always put $reflectConstruct on the builtins.
> > 
> > I think I am confused about what is shipping and what isn't. How can
> > Parser::SpreadCall desugar to %ReflectConstruct? Aren't classes with super
> calls
> > as well as spread calls shipping?
> 
> Oh boy, in Genesis::InitializeGlobal_harmony_reflect we already explicitly
check
> for FLAG_harmony_spreadcalls as well. How about we just remove this hack there
> and just always install $reflectApply and $reflectConstruct instead?

Done. I did so on the third patch set.

[rossberg, 2015-07-20 13:24:45]

lgtm

[Michael Starzinger, 2015-07-20 13:49:02]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-07-20 13:49:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240993002/40001

[commit-bot: I haz the power, 2015-07-20 13:50:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-20 13:50:37]

Patchset 3 (id:??) landed as
https://crrev.com/37c2094e8c956e4ef816e7de1a2da9db78e5623d
Cr-Commit-Position: refs/heads/master@{#29753}