Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 12456007: Add Precise try slaves: vm[750-781]-m4 (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org
Visibility:
Public.

Description

Add Precise try slaves: vm[750-781]-m4 This also adds a dbg Precise trybot. And also removes Lucid try slaves vm[384-429]-m4 so they can be upgraded to Precise. BUG=177182 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187169

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M build/masters/master.tryserver.chromium/master.cfg View 1 2 3 4 2 chunks +14 lines, -1 line 0 comments Download
M build/masters/master.tryserver.chromium/slaves.cfg View 1 2 3 4 2 chunks +3 lines, -5 lines 2 comments Download

Messages

Total messages: 15 (0 generated)
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-05 18:34:59 UTC) #1
Paweł Hajdan Jr.
+Isaac
7 years, 9 months ago (2013-03-05 20:49:40 UTC) #2
Paweł Hajdan Jr.
+Ryan - mostly as FYI, but feedback welcome just in case
7 years, 9 months ago (2013-03-05 21:46:40 UTC) #3
Isaac (away)
lgtm
7 years, 9 months ago (2013-03-06 00:28:42 UTC) #4
Paweł Hajdan Jr.
I have also added a dbg trybot as requested - could you review again?
7 years, 9 months ago (2013-03-06 00:58:34 UTC) #5
Isaac (away)
lgtm w/ 1 change https://codereview.chromium.org/12456007/diff/8001/build/masters/master.tryserver.chromium/master.cfg File build/masters/master.tryserver.chromium/master.cfg (right): https://codereview.chromium.org/12456007/diff/8001/build/masters/master.tryserver.chromium/master.cfg#newcode509 build/masters/master.tryserver.chromium/master.cfg:509: slavebuilddir='linux_dbg_precise', change this to 'linux_precise'
7 years, 9 months ago (2013-03-06 01:00:30 UTC) #6
Paweł Hajdan Jr.
https://codereview.chromium.org/12456007/diff/8001/build/masters/master.tryserver.chromium/master.cfg File build/masters/master.tryserver.chromium/master.cfg (right): https://codereview.chromium.org/12456007/diff/8001/build/masters/master.tryserver.chromium/master.cfg#newcode509 build/masters/master.tryserver.chromium/master.cfg:509: slavebuilddir='linux_dbg_precise', On 2013/03/06 01:00:30, Isaac wrote: > change this ...
7 years, 9 months ago (2013-03-06 01:04:13 UTC) #7
Isaac (away)
oh also can you update the description to mention that you are adding a trybot?
7 years, 9 months ago (2013-03-06 01:06:36 UTC) #8
Paweł Hajdan Jr.
On 2013/03/06 01:06:36, Isaac wrote: > oh also can you update the description to mention ...
7 years, 9 months ago (2013-03-06 01:13:34 UTC) #9
Isaac (away)
thanks. still lgtm
7 years, 9 months ago (2013-03-06 17:48:58 UTC) #10
M-A Ruel
what about just adding the precise slaves and slowly removing the lucid slaves as they ...
7 years, 9 months ago (2013-03-06 19:59:05 UTC) #11
Paweł Hajdan Jr.
On 2013/03/06 19:59:05, Marc-Antoine Ruel wrote: > what about just adding the precise slaves and ...
7 years, 9 months ago (2013-03-07 18:23:31 UTC) #12
M-A Ruel
lgtm https://codereview.chromium.org/12456007/diff/17001/build/masters/master.tryserver.chromium/slaves.cfg File build/masters/master.tryserver.chromium/slaves.cfg (left): https://codereview.chromium.org/12456007/diff/17001/build/masters/master.tryserver.chromium/slaves.cfg#oldcode43 build/masters/master.tryserver.chromium/slaves.cfg:43: normal_slaves = range(384, 430) Just so I understand ...
7 years, 9 months ago (2013-03-07 18:34:56 UTC) #13
Paweł Hajdan Jr.
https://codereview.chromium.org/12456007/diff/17001/build/masters/master.tryserver.chromium/slaves.cfg File build/masters/master.tryserver.chromium/slaves.cfg (left): https://codereview.chromium.org/12456007/diff/17001/build/masters/master.tryserver.chromium/slaves.cfg#oldcode43 build/masters/master.tryserver.chromium/slaves.cfg:43: normal_slaves = range(384, 430) On 2013/03/07 18:34:56, Marc-Antoine Ruel ...
7 years, 9 months ago (2013-03-07 18:44:44 UTC) #14
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-09 20:46:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 manually as r187169.

Powered by Google App Engine
This is Rietveld 408576698