Issue 1245483002: Revert of Disable smoothness.top_25_smooth on win/mac/linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1245483002: Revert of Disable smoothness.top_25_smooth on win/mac/linux. (Closed)

Created:
5 years, 5 months ago by shatch

Modified:
5 years, 5 months ago

Reviewers:
sullivan

CC:
chromium-reviews, telemetry-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Disable smoothness.top_25_smooth on win/mac/linux. (patchset #1 id:1 of https://codereview.chromium.org/1238073003/) Reason for revert: This was caused by https://codereview.chromium.org/1234223003, which has been reverted. BUG=510818 Original issue's description: > Disable smoothness.top_25_smooth on win/mac/linux. > > BUG=510818 > > Committed: https://crrev.com/d143ef088ec1069825eb9a585d82be3b4ccc9ce6 > Cr-Commit-Position: refs/heads/master@{#339041} TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510818 Committed: https://crrev.com/9e04ff6e861e62e2023c1f74fe1a479356e78e73 Cr-Commit-Position: refs/heads/master@{#339259}

Patch Set 1 #

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tools/perf/benchmarks/smoothness.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

shatch

Created Revert of Disable smoothness.top_25_smooth on win/mac/linux.

5 years, 5 months ago (2015-07-17 15:36:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245483002/1

5 years, 5 months ago (2015-07-17 15:36:34 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/9e04ff6e861e62e2023c1f74fe1a479356e78e73 Cr-Commit-Position: refs/heads/master@{#339259}

5 years, 5 months ago (2015-07-17 15:39:31 UTC) #4

majidvp

5 years, 5 months ago (2015-07-17 19:45:28 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1241483003/ by majidvp@chromium.org.

The reason for reverting is: Disabling the test smoothness.top_25_smooth on
win/mac/linux again. 

The test is still causing perf bot failure. .

Expand Messages | Collapse Messages