Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1234223003: Enable checks for outdated plugins even when third-party plugin installation is not enabled. (Closed)

Created:
5 years, 5 months ago by Bernhard Bauer
Modified:
5 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable checks for outdated plugins even when third-party plugin installation is not enabled. Even built-in plugins can be outdated, in particular if plugin metadata is updated separately from a Chrome update. BUG=509832 Committed: https://crrev.com/364aa7f794daadbe497a0ad02621aa1d5a400a49 Cr-Commit-Position: refs/heads/master@{#338869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/plugins/plugin_info_message_filter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bernhard Bauer
Please review.
5 years, 5 months ago (2015-07-15 16:33:25 UTC) #2
Will Harris
lgtm thanks for doing this
5 years, 5 months ago (2015-07-15 16:36:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234223003/1
5 years, 5 months ago (2015-07-15 16:42:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 17:00:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/364aa7f794daadbe497a0ad02621aa1d5a400a49 Cr-Commit-Position: refs/heads/master@{#338869}
5 years, 5 months ago (2015-07-15 17:01:13 UTC) #7
Bernhard Bauer
5 years, 5 months ago (2015-07-16 09:10:03 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1241693003/ by bauerb@chromium.org.

The reason for reverting is: Crashes when encountering an outdated plugin on
Linux/CrOS (https://crbug.com/510684 and https://crbug.com/510567)..

Powered by Google App Engine
This is Rietveld 408576698