Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1245363002: Add WebUSB bindings and client interface (Closed)

Created:
5 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebUSB bindings and client interface BUG=492204

Patch Set 1 : #

Total comments: 22

Patch Set 2 : cleanup, better error reporting #

Total comments: 18

Patch Set 3 : iface ctors, OWNERS, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1912 lines, -0 lines) Patch
M Source/modules/modules.gypi View 1 2 5 chunks +39 lines, -0 lines 0 comments Download
A Source/modules/webusb/NavigatorUSB.h View 1 chunk +39 lines, -0 lines 0 comments Download
A Source/modules/webusb/NavigatorUSB.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
A Source/modules/webusb/NavigatorUSB.idl View 1 1 chunk +10 lines, -0 lines 0 comments Download
A Source/modules/webusb/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A Source/modules/webusb/USB.h View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A Source/modules/webusb/USB.cpp View 1 chunk +102 lines, -0 lines 0 comments Download
A Source/modules/webusb/USB.idl View 1 chunk +11 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBAlternateInterface.h View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBAlternateInterface.cpp View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBAlternateInterface.idl View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConfiguration.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConfiguration.cpp View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConfiguration.idl View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBControlTransferParameters.idl View 1 1 chunk +24 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBController.h View 1 chunk +42 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBController.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBDevice.h View 1 chunk +73 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBDevice.cpp View 1 1 chunk +271 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBDevice.idl View 1 chunk +38 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBDeviceEnumerationOptions.idl View 1 1 chunk +7 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBDeviceFilter.idl View 1 chunk +11 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBEndpoint.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBEndpoint.cpp View 1 2 1 chunk +99 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBEndpoint.idl View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBError.h View 1 chunk +32 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBError.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBInTransferResult.h View 1 chunk +43 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBInTransferResult.idl View 1 chunk +11 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBInterface.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBInterface.cpp View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBInterface.idl View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBOutTransferResult.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBOutTransferResult.idl View 1 chunk +11 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBTransferStatus.idl View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A public/platform/modules/webusb/WebUSBClient.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A public/platform/modules/webusb/WebUSBDevice.h View 1 2 1 chunk +105 lines, -0 lines 0 comments Download
A public/platform/modules/webusb/WebUSBDeviceEnumerationOptions.h View 1 chunk +20 lines, -0 lines 0 comments Download
A public/platform/modules/webusb/WebUSBDeviceFilter.h View 1 chunk +34 lines, -0 lines 0 comments Download
A public/platform/modules/webusb/WebUSBDeviceInfo.h View 1 chunk +109 lines, -0 lines 0 comments Download
A public/platform/modules/webusb/WebUSBError.h View 1 chunk +34 lines, -0 lines 0 comments Download
A public/platform/modules/webusb/WebUSBTransferInfo.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Ken Rockot(use gerrit already)
Reilly, FYI here's the Blink patch in its current form. Will need to be updated ...
5 years, 5 months ago (2015-07-21 22:09:29 UTC) #2
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1245363002/diff/40001/Source/modules/webusb/NavigatorUSB.idl File Source/modules/webusb/NavigatorUSB.idl (right): https://codereview.chromium.org/1245363002/diff/40001/Source/modules/webusb/NavigatorUSB.idl#newcode1 Source/modules/webusb/NavigatorUSB.idl:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 5 months ago (2015-07-23 23:24:09 UTC) #4
Ken Rockot(use gerrit already)
Thanks, all comments addressed https://codereview.chromium.org/1245363002/diff/40001/Source/modules/webusb/NavigatorUSB.idl File Source/modules/webusb/NavigatorUSB.idl (right): https://codereview.chromium.org/1245363002/diff/40001/Source/modules/webusb/NavigatorUSB.idl#newcode1 Source/modules/webusb/NavigatorUSB.idl:1: // Copyright 2014 The Chromium ...
5 years, 4 months ago (2015-07-28 22:30:39 UTC) #5
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1245363002/diff/60001/Source/modules/webusb/USB.h File Source/modules/webusb/USB.h (right): https://codereview.chromium.org/1245363002/diff/60001/Source/modules/webusb/USB.h#newcode31 Source/modules/webusb/USB.h:31: // USBDeviceEnumeration interface: I think this comment is obsolete. ...
5 years, 4 months ago (2015-07-28 22:51:43 UTC) #6
Ken Rockot(use gerrit already)
I also added web constructors for our informational interfaces (config, interface, alternate, endpoint). https://codereview.chromium.org/1245363002/diff/60001/Source/modules/webusb/USB.h File ...
5 years, 4 months ago (2015-07-28 23:21:39 UTC) #7
Reilly Grant (use Gerrit)
lgtm
5 years, 4 months ago (2015-07-28 23:27:56 UTC) #8
Ken Rockot(use gerrit already)
haraken@ could you please review as Source/modules owners? FYI intent-to-implement thread is linked in the ...
5 years, 4 months ago (2015-07-29 17:04:54 UTC) #13
haraken
On 2015/07/29 17:04:54, Ken Rockot wrote: > haraken@ could you please review as Source/modules owners? ...
5 years, 4 months ago (2015-07-29 17:13:09 UTC) #14
Ken Rockot(use gerrit already)
On 2015/07/29 17:13:09, haraken wrote: > On 2015/07/29 17:04:54, Ken Rockot wrote: > > haraken@ ...
5 years, 4 months ago (2015-07-29 17:14:52 UTC) #15
haraken
5 years, 4 months ago (2015-07-29 17:34:32 UTC) #16 
On 2015/07/29 17:14:52, Ken Rockot wrote:
> On 2015/07/29 17:13:09, haraken wrote:
> > On 2015/07/29 17:04:54, Ken Rockot wrote:
> > > haraken@ could you please review as Source/modules owners?
> > > 
> > > FYI intent-to-implement thread is linked in the associated crbug.
> > 
> > This CL is way too big to review in one go... Would it be possible to split
> the
> > CL into pieces and land them more incrementally?
> 
> Sure, I'll break it up a bit

Thanks, I understand that it will increase the cost of landing your change but
that's the way we keep the code base clean and safe :)

Powered by Google App Engine
This is Rietveld 408576698