Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1245243002: Move dart_debugger into tonic and use it in mojo dart controller (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move dart_debugger into tonic and use it in mojo dart controller R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ffdf1e7dc3fac825acef92f8dc24d691d63a96bb

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -319 lines) Patch
M mojo/dart/embedder/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/dart/embedder/dart_debugger.h View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/dart/embedder/dart_debugger.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D mojo/dart/embedder/monitor.h View 1 chunk +0 lines, -77 lines 0 comments Download
M tonic/BUILD.gn View 1 2 chunks +8 lines, -0 lines 0 comments Download
A + tonic/dart_debugger.h View 2 chunks +64 lines, -8 lines 0 comments Download
A + tonic/dart_debugger.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 5 months ago (2015-07-21 17:48:56 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1245243002/diff/1/tonic/BUILD.gn File tonic/BUILD.gn (right): https://codereview.chromium.org/1245243002/diff/1/tonic/BUILD.gn#newcode65 tonic/BUILD.gn:65: include_dirs = [ "//dart/runtime" ] Do we need ...
5 years, 5 months ago (2015-07-21 18:02:41 UTC) #4
Cutch
https://codereview.chromium.org/1245243002/diff/1/tonic/BUILD.gn File tonic/BUILD.gn (right): https://codereview.chromium.org/1245243002/diff/1/tonic/BUILD.gn#newcode65 tonic/BUILD.gn:65: include_dirs = [ "//dart/runtime" ] On 2015/07/21 18:02:41, abarth-chromium ...
5 years, 5 months ago (2015-07-21 18:09:16 UTC) #5
Cutch
5 years, 5 months ago (2015-07-21 18:09:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ffdf1e7dc3fac825acef92f8dc24d691d63a96bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698