mojo/dart/embedder/dart_controller.cc - Issue 1245243002: Move dart_debugger into tonic and use it in mojo dart controller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/embedder/dart_controller.cc

Issue 1245243002: Move dart_debugger into tonic and use it in mojo dart controller (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/embedder/dart_controller.cc

diff --git a/mojo/dart/embedder/dart_controller.cc b/mojo/dart/embedder/dart_controller.cc

index 1c676869d965f05bbcfda6e5e9f602a2ba30ef65..e3a14e38a4be0da971fa0c4c289bacff1b69e79f 100644

--- a/mojo/dart/embedder/dart_controller.cc

+++ b/mojo/dart/embedder/dart_controller.cc

@@ -12,10 +12,10 @@

#include "dart/runtime/include/dart_native_api.h"

#include "mojo/dart/embedder/builtin.h"

#include "mojo/dart/embedder/dart_controller.h"

-#include "mojo/dart/embedder/dart_debugger.h"

#include "mojo/dart/embedder/dart_state.h"

#include "mojo/dart/embedder/vmservice.h"

#include "mojo/public/c/system/core.h"

+#include "tonic/dart_debugger.h"

namespace mojo {

namespace dart {

@@ -562,7 +562,7 @@ void DartController::InitVmIfNeeded(Dart_EntropySource entropy,

CHECK(result);

// This should be called before calling Dart_Initialize.

- DartDebugger::InitDebugger();

+ tonic::DartDebugger::InitDebugger();

result = Dart_Initialize(vm_isolate_snapshot_buffer,

IsolateCreateCallback,

« no previous file with comments | « mojo/dart/embedder/BUILD.gn ('k') | mojo/dart/embedder/dart_debugger.h » ('j') | no next file with comments »