Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1245223007: Revert of skia: ANGLE deps roll (Closed)

Created:
5 years, 5 months ago by hendrikw
Modified:
5 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of skia: ANGLE deps roll (patchset #1 id:1 of https://codereview.chromium.org/1244843003/) Reason for revert: Compile error that the try bots didn't catch :( Original issue's description: > ANGLE deps roll > > If we ever want to allow the command buffer as a skia gles2 backend, > we need a more up to date version of ANGLE, specifically there are > 4 defines that differ between newer and older versions of ANGLE which > we use in skia, I've updated these in this change. > > I'm not quite sure if what I've done for the 'angle_path' is correct, > I tried setting it to a path relative to skia, and to '<(DEPTH)', both > of which do not compile correctly, only '../' worked. > > Committed: https://skia.googlesource.com/skia/+/db0b1e796ddbd08e6be8a666537318b1c0e2ce56 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/cd94d7341f454ba7acb090f63ef99fdbf5bba415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_variables.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/angle/SkANGLEGLContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hendrikw
Created Revert of skia: ANGLE deps roll
5 years, 5 months ago (2015-07-21 20:24:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245223007/1
5 years, 5 months ago (2015-07-21 20:24:22 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-21 20:24:23 UTC) #3
bsalomon
On 2015/07/21 20:24:23, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 5 months ago (2015-07-21 21:04:44 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:06:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd94d7341f454ba7acb090f63ef99fdbf5bba415

Powered by Google App Engine
This is Rietveld 408576698