Move pref backing up flags from local state to device settings on ChromeOS.

chrome/browser/ui/webui/flags_ui.cc

Index: chrome/browser/ui/webui/flags_ui.cc
diff --git a/chrome/browser/ui/webui/flags_ui.cc b/chrome/browser/ui/webui/flags_ui.cc
index 098ea91708086e9c282658bb3dea9edefd25745d..8fad4fffd4b37e7aa83efe793850e46cf6d81002 100644
--- a/chrome/browser/ui/webui/flags_ui.cc
+++ b/chrome/browser/ui/webui/flags_ui.cc
@@ -219,8 +219,7 @@ void FlagsUI::FinishInitialization(
   if (!current_user_is_owner) {
     web_ui()->AddMessageHandler(new FlagsDOMHandler(profile->GetPrefs()));
   } else {
-    web_ui()->AddMessageHandler(
-        new FlagsDOMHandler(g_browser_process->local_state()));
+    web_ui()->AddMessageHandler(new FlagsDOMHandler(NULL));

[Joao da Silva, 2013/03/05 17:46:30]

Tracking that |prefs| variable around about_flags.cc isn't easy, and it's not
immediately clear that the NULL won't be used. It's very easy to extend one of
those functions in the future and just dereference the |prefs| argument, and
boom.

Maybe not in this CL, but about_flags.cc could be refactored to use an abstract
interface to read/set flags which is passed from here; the default impl uses a
PrefService, and on ChromeOS it uses another impl backed by CrosSettings. I
think that'd be much cleaner.

[pastarmovj, 2013/03/06 17:28:31]

Ack. I'd rather keep this work for a later CL.

     // If the owner managed to set the flags pref on his own profile clear it
     // because it will never be accessible anymore.
     if (profile->GetPrefs()->HasPrefPath(prefs::kEnabledLabsExperiments))