Move pref backing up flags from local state to device settings on ChromeOS.

chrome/browser/ui/webui/flags_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/flags_ui.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 201 matching lines @@
 
 void FlagsUI::FinishInitialization(
     Profile* profile,
     chromeos::DeviceSettingsService::OwnershipStatus status,
     bool current_user_is_owner) {
   // On Chrome OS the owner can set system wide flags and other users can only
   // set flags for their own session.
   if (!current_user_is_owner) {
     web_ui()->AddMessageHandler(new FlagsDOMHandler(profile->GetPrefs()));
   } else {
-    web_ui()->AddMessageHandler(
-        new FlagsDOMHandler(g_browser_process->local_state()));
+    web_ui()->AddMessageHandler(new FlagsDOMHandler(NULL));

[Joao da Silva, 2013/03/05 17:46:30]

Tracking that |prefs| variable around about_flags.cc isn't easy, and it's not
immediately clear that the NULL won't be used. It's very easy to extend one of
those functions in the future and just dereference the |prefs| argument, and
boom.

Maybe not in this CL, but about_flags.cc could be refactored to use an abstract
interface to read/set flags which is passed from here; the default impl uses a
PrefService, and on ChromeOS it uses another impl backed by CrosSettings. I
think that'd be much cleaner.

[pastarmovj, 2013/03/06 17:28:31]

Ack. I'd rather keep this work for a later CL.

     // If the owner managed to set the flags pref on his own profile clear it
     // because it will never be accessible anymore.
     if (profile->GetPrefs()->HasPrefPath(prefs::kEnabledLabsExperiments))
       profile->GetPrefs()->ClearPref(prefs::kEnabledLabsExperiments);
   }
 
   // Set up the about:flags source.
   content::WebUIDataSource::Add(profile, CreateFlagsUIHTMLSource());
 }
 #endif