Misc cleanup

Misc cleanup

This is split off of https://codereview.chromium.org/1225923010/ (Start tightening correspondence betweeen GrDrawContext and GrRenderTarget). It:

fixes some style nits
replaces some passing of GrContext with GrTextureProvider & GrDrawContext
does a bit of the finer grained creation of GrDrawContexts

Committed: https://skia.googlesource.com/skia/+/ff0ca5ed825d9106edc2df6ab3865e1c17c326bf

[robertphillips, 2015-07-21 20:08:30]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2015-07-22 16:20:37]

ping

[bsalomon, 2015-07-22 16:29:17]

pong

https://codereview.chromium.org/1245183002/diff/100001/include/core/SkMaskFil...
File include/core/SkMaskFilter.h (right):

https://codereview.chromium.org/1245183002/diff/100001/include/core/SkMaskFil...
include/core/SkMaskFilter.h:100: virtual bool
directFilterMaskGPU(GrTextureProvider* texProvider,
What do you think about DrawContext having a ref on TextureProvider (and caps?)?
Maybe there are use cases for DrawContext where the contract is "you can draw
but you can't create textures!!" but I'm not sure since inputs sometimes are
SkBitmap/raster-SkImages that need to be uploaded.

[bsalomon, 2015-07-22 16:46:50]

lgtm

[robertphillips, 2015-07-22 16:47:02]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-22 16:47:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245183002/100001

[commit-bot: I haz the power, 2015-07-22 16:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 16:48:03]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2015-07-22 18:30:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-22 18:30:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245183002/120001

[commit-bot: I haz the power, 2015-07-22 18:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 18:38:08]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-07-22 18:54:01]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-07-22 18:54:01]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1245183002/#ps120001
(title: "Address gcc complaint")

[commit-bot: I haz the power, 2015-07-22 18:54:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1245183002/120001

[commit-bot: I haz the power, 2015-07-22 18:54:47]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/ff0ca5ed825d9106edc2df6ab3865e1c17c326bf

[brucedawson, 2015-07-23 17:52:11]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-07-23 17:52:12]

Note that /analyze pointed out some (benign) variable shadowing.

https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
File src/effects/SkMorphologyImageFilter.cpp (right):

https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:675: GrTexture* dst =
context->textureProvider()->refScratchTexture(
'dst' is a confusing variable name to use here because it shadows the function
parameter of the same name. This appears to be harmless but it is confusing.

https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:699: GrTexture* dst =
context->textureProvider()->refScratchTexture(desc,
Ditto. FWIW.

https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
src/effects/SkMorphologyImageFilter.cpp:715:
SkImageFilter::WrapTexture(srcTexture, rect.width(), rect.height(), dst);
This appears to be the only one of the seven references to 'dst' which refers to
the function parameter.

[robertphillips, 2015-07-23 18:35:29]

On 2015/07/23 17:52:12, brucedawson wrote:
> Note that /analyze pointed out some (benign) variable shadowing.
> 
>
https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
> File src/effects/SkMorphologyImageFilter.cpp (right):
> 
>
https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
> src/effects/SkMorphologyImageFilter.cpp:675: GrTexture* dst =
> context->textureProvider()->refScratchTexture(
> 'dst' is a confusing variable name to use here because it shadows the function
> parameter of the same name. This appears to be harmless but it is confusing.
> 
>
https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
> src/effects/SkMorphologyImageFilter.cpp:699: GrTexture* dst =
> context->textureProvider()->refScratchTexture(desc,
> Ditto. FWIW.
> 
>
https://codereview.chromium.org/1245183002/diff/120001/src/effects/SkMorpholo...
> src/effects/SkMorphologyImageFilter.cpp:715:
> SkImageFilter::WrapTexture(srcTexture, rect.width(), rect.height(), dst);
> This appears to be the only one of the seven references to 'dst' which refers
to
> the function parameter.
 
Should be taken care of in: https://codereview.chromium.org/1245883005/ (Fix
variable shadowing in SkMorphologyImageFilter)