Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1245173002: MIPS: Fix simulator data trace for DSLL and BAL/BGEZAL. (Closed)

Created:
5 years, 5 months ago by Ilija.Pavlovic1
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix simulator data trace for DSLL and BAL/BGEZAL. In simulator data trace, DSLL did not print result and BAL/BGEZAL omitted result from an instruction executed in delay slot. TEST=cctest/test-assembler-mips[64] BUG= Committed: https://crrev.com/a5f5f5801440e6b4d25be37441a65af2add9a7ef Cr-Commit-Position: refs/heads/master@{#29796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -5 lines) Patch
M src/mips/disasm-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/mips/simulator-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ilija.Pavlovic1
5 years, 5 months ago (2015-07-21 13:50:47 UTC) #2
paul.l...
Code LGTM. Commit message has some nits, please fix before committing: Please don't use '[64]' ...
5 years, 5 months ago (2015-07-23 05:01:48 UTC) #3
Ilija.Pavlovic1
On 2015/07/23 05:01:48, paul.l... wrote: > Code LGTM. > > Commit message has some nits, ...
5 years, 5 months ago (2015-07-23 07:06:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245173002/1
5 years, 5 months ago (2015-07-23 07:06:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 07:30:02 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 07:30:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5f5f5801440e6b4d25be37441a65af2add9a7ef
Cr-Commit-Position: refs/heads/master@{#29796}

Powered by Google App Engine
This is Rietveld 408576698