Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: src/mips/disasm-mips.cc

Issue 1245173002: MIPS: Fix simulator data trace for DSLL and BAL/BGEZAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/mips/simulator-mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mips/disasm-mips.cc
diff --git a/src/mips/disasm-mips.cc b/src/mips/disasm-mips.cc
index 48427c54558650e2e3d2a8402af116ac5ba8f227..1d505750a5026626ecf97708c61d36288a248c3f 100644
--- a/src/mips/disasm-mips.cc
+++ b/src/mips/disasm-mips.cc
@@ -1346,9 +1346,13 @@ void Decoder::DecodeTypeImmediate(Instruction* instr) {
case BGEZ:
Format(instr, "bgez 'rs, 'imm16u -> 'imm16p4s2");
break;
- case BGEZAL:
- Format(instr, "bgezal 'rs, 'imm16u -> 'imm16p4s2");
+ case BGEZAL: {
+ if (instr->RsValue() == 0)
+ Format(instr, "bal 'imm16s -> 'imm16p4s2");
+ else
+ Format(instr, "bgezal 'rs, 'imm16u -> 'imm16p4s2");
break;
+ }
case BGEZALL:
Format(instr, "bgezall 'rs, 'imm16u -> 'imm16p4s2");
break;
« no previous file with comments | « no previous file | src/mips/simulator-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698