Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1245093004: Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_fo… (Closed)

Created:
5 years, 5 months ago by epertoso
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_for_size are set. R=jochen@chromium.org Committed: https://crrev.com/143f5ad89305a82649d3606bc400e0ec64149e50 Cr-Commit-Position: refs/heads/master@{#29771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/global-handles.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
epertoso
5 years, 5 months ago (2015-07-21 10:24:43 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245093004/1
5 years, 5 months ago (2015-07-21 10:24:55 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-21 10:45:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 10:49:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245093004/1
5 years, 5 months ago (2015-07-21 10:50:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 10:52:48 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 10:53:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/143f5ad89305a82649d3606bc400e0ec64149e50
Cr-Commit-Position: refs/heads/master@{#29771}

Powered by Google App Engine
This is Rietveld 408576698