Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/global-handles.cc

Issue 1245093004: Always run the second pass of the phantom callbacks synchronously if --predictable or --optimize_fo… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/global-handles.cc
diff --git a/src/global-handles.cc b/src/global-handles.cc
index ab48997c58ecae4c1850dd14fd2ead507d0374a5..444614c166c0a0203e8af2b530215efecbcc54cf 100644
--- a/src/global-handles.cc
+++ b/src/global-handles.cc
@@ -840,7 +840,7 @@ int GlobalHandles::DispatchPendingPhantomCallbacks(
}
}
if (pending_phantom_callbacks_.length() > 0) {
- if (synchronous_second_pass) {
+ if (FLAG_optimize_for_size || FLAG_predictable || synchronous_second_pass) {
InvokeSecondPassPhantomCallbacks(&pending_phantom_callbacks_, isolate());
} else {
auto task = new PendingPhantomCallbacksSecondPassTask(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698