Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 1244773003: Remove unusued instance variable of chrome::VersionInfo. (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unusued instance variable of chrome::VersionInfo. The instance variable chrome::VersionInfo::version_info_ is never used and can be safely removed. Also remove the forward-declaration of the FileVersionInfo class and the corresponding #include in the implementation file. BUG=None Committed: https://crrev.com/1067392cb46b944e198f085fad7e226d700ad070 Cr-Commit-Position: refs/heads/master@{#339851}

Patch Set 1 #

Patch Set 2 : Add missing #include in chrome/app/close_handle_hook_win.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/app/close_handle_hook_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_version_info.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_version_info.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 5 months ago (2015-07-20 18:32:15 UTC) #2
James Hawkins
lgtm
5 years, 5 months ago (2015-07-21 19:04:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244773003/20001
5 years, 5 months ago (2015-07-22 08:39:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 09:11:22 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 09:12:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1067392cb46b944e198f085fad7e226d700ad070
Cr-Commit-Position: refs/heads/master@{#339851}

Powered by Google App Engine
This is Rietveld 408576698