chrome/common/chrome_version_info.cc - Issue 1244773003: Remove unusued instance variable of chrome::VersionInfo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/chrome_version_info.cc

Issue 1244773003: Remove unusued instance variable of chrome::VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing #include in chrome/app/close_handle_hook_win.cc Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/chrome_version_info.h"	5 #include "chrome/common/chrome_version_info.h"

6	6

7 #include "base/basictypes.h"	7 #include "base/basictypes.h"

8 #include "base/file_version_info.h"

9 #include "base/profiler/scoped_tracker.h"	8 #include "base/profiler/scoped_tracker.h"

10 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

11 #include "base/threading/thread_restrictions.h"	10 #include "base/threading/thread_restrictions.h"

12 #include "build/build_config.h"	11 #include "build/build_config.h"

13 #include "chrome/common/chrome_version_info_values.h"	12 #include "chrome/common/chrome_version_info_values.h"

14 #include "chrome/grit/chromium_strings.h"	13 #include "chrome/grit/chromium_strings.h"

15 #include "chrome/grit/generated_resources.h"	14 #include "chrome/grit/generated_resources.h"

16 #include "ui/base/l10n/l10n_util.h"	15 #include "ui/base/l10n/l10n_util.h"

17	16

18 namespace chrome {	17 namespace chrome {

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
111 return "canary";	110 return "canary";

112 break;	111 break;

113 case chrome::VersionInfo::CHANNEL_UNKNOWN:	112 case chrome::VersionInfo::CHANNEL_UNKNOWN:

114 return "unknown";	113 return "unknown";

115 break;	114 break;

116 }	115 }

117 return std::string();	116 return std::string();

118 }	117 }

119	118

120 } // namespace chrome	119 } // namespace chrome

OLD	NEW

« no previous file with comments | « chrome/common/chrome_version_info.h ('k') | no next file » | no next file with comments »