Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 12447009: MIPS: ES6 symbols: Implement Symbol intrinsic and basic functionality (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: ES6 symbols: Implement Symbol intrinsic and basic functionality Port r13786 (b5e7a82a) Original commit message: - Add --harmony-symbols flag. - Add Symbol constructor; allow symbols as (unreplaced) return value from constructors. - Introduce %CreateSymbol and %_IsSymbol natives and respective instructions. - Extend 'typeof' code generation to handle symbols. - Extend CompareIC with a UNIQUE_NAMES state that (uniformly) handles internalized strings and symbols. - Property lookup delegates to SymbolDelegate object for symbols, which only carries the toString method. - Extend Object.prototype.toString to recognise symbols. Per the current draft spec, symbols are actually pseudo objects that are frozen with a null prototype and only one property (toString). For simplicity, we do not treat them as proper objects for now, although typeof will return "object". Only property access works as if they were (frozen) objects (via the internal delegate object). (Baseline CL: https://codereview.chromium.org/12223071/) BUG= Committed: https://code.google.com/p/v8/source/detail?r=13871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -5 lines) Patch
M src/mips/builtins-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +14 lines, -4 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 9 months ago (2013-03-06 01:59:59 UTC) #1
rossberg
lgtm
7 years, 9 months ago (2013-03-07 12:33:56 UTC) #2
palfia
7 years, 9 months ago (2013-03-08 00:43:07 UTC) #3
Message was sent while issue was closed.
Committed manually as r13871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698