src/x64/lithium-x64.cc - Issue 1244693002: Add support for adding an external and a tagged pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 1244693002: Add support for adding an external and a tagged pointer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index 3c150e21c91d8abc494fdceed031b3801d0c0680..ae454fe2a63f7e7bbb993e9cb0315e61cae8f3e5 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -1606,7 +1606,8 @@ LInstruction* LChunkBuilder::DoAdd(HAdd* instr) {

return result;

} else if (instr->representation().IsExternal()) {

DCHECK(instr->left()->representation().IsExternal());

- DCHECK(instr->right()->representation().IsInteger32());

+ DCHECK(instr->right()->representation().IsInteger32() ||

+ instr->right()->representation().IsTagged());

DCHECK(!instr->CheckFlag(HValue::kCanOverflow));

bool use_lea = LAddI::UseLea(instr);

LOperand* left = UseRegisterAtStart(instr->left());