Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: src/hydrogen-instructions.h

Issue 1244693002: Add support for adding an external and a tagged pointer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index b7e9903f05aa078e458654341a77b464fc231e33..b133efd0f39e902d89d0db47d425289ebf2707e4 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -4886,6 +4886,10 @@ class HAdd final : public HArithmeticBinaryOperation {
HAdd(HValue* context, HValue* left, HValue* right, Strength strength)
: HArithmeticBinaryOperation(context, left, right, strength) {
SetFlag(kCanOverflow);
+ if (left->representation().IsExternal() &&
+ right->representation().IsTagged()) {
Jarin 2015/07/20 08:52:32 This looks quite brittle, perhaps we should introd
Michael Starzinger 2015/07/20 08:56:38 +1
+ SetDependsOnFlag(kNewSpacePromotion);
+ }
}
};
« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698