Issue 1244523002: Revert of Add fast normalize for SkLightingImageFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1244523002: Revert of Add fast normalize for SkLightingImageFilter. (Closed)

Created:
5 years, 5 months ago by reed2

Modified:
5 years, 5 months ago

Reviewers:
jvanverth1, Stephen White, senorblanco, reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Add fast normalize for SkLightingImageFilter. (patchset #2 id:20001 of https://codereview.chromium.org/1240023002/) Reason for revert: Speculative revert -- DEPS roll block on linux_blink_rel https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/71483/layout-test-results/results.html Original issue's description: > Add fast normalize for SkLightingImageFilter. > > The normalize routine in SkPoint3 is very robust. However, for simple > lighting cases we prefer speed over robustness. This fixes a perf > regression in smoothness.tough_filters_cases. > > BUG=chromium:510562 > > Committed: https://skia.googlesource.com/skia/+/dfa0ecf169db87f7afddd93bc1c500de481a62c7 TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:510562 Committed: https://skia.googlesource.com/skia/+/ac66a8122b27c388cc74b3913d9a9be351a44e54

Patch Set 1 #

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -15 lines)			Patch
	M	src/effects/SkLightingImageFilter.cpp	View		7 chunks	+6 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed2

Created Revert of Add fast normalize for SkLightingImageFilter.

5 years, 5 months ago (2015-07-16 23:02:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244523002/1

5 years, 5 months ago (2015-07-16 23:02:32 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ac66a8122b27c388cc74b3913d9a9be351a44e54

5 years, 5 months ago (2015-07-16 23:02:41 UTC) #3

jvanverth1

5 years, 5 months ago (2015-07-17 14:22:17 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1241583007/ by jvanverth@google.com.

The reason for reverting is: Florin will rebaseline the images..

Expand Messages | Collapse Messages