Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: pkg/compiler/lib/src/deferred_load.dart

Issue 1244513003: dart2js: fix dependency tracking for deferred loading when types are only used (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/deferred_load.dart
diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart
index 3213f9f52dfbaad0b5fd6e5ee88e0e7c20b1916d..92aa9094704093940ddfadfaed6d0a290a0a39e0 100644
--- a/pkg/compiler/lib/src/deferred_load.dart
+++ b/pkg/compiler/lib/src/deferred_load.dart
@@ -280,6 +280,19 @@ class DeferredLoadTask extends CompilerTask {
elements.add(dependency);
}
+
+ treeElements.forEachType((n, t) {
+ registerTypeArgumentsAsDependencies(type) {
floitsch 2015/07/17 09:22:25 Especially for nested functions I want to have a r
Siggi Cherem (dart-lang) 2015/07/17 15:34:48 Done.
+ var dependency = type.element;
floitsch 2015/07/17 09:22:25 We usually don't use "var".
Siggi Cherem (dart-lang) 2015/07/17 15:34:49 Done.
+ if (dependency == null || dependency.isTypeVariable) return;
+ elements.add(dependency);
+ if (type is GenericType) {
+ type.typeArguments.forEach(registerTypeArgumentsAsDependencies);
+ }
+ }
+ if (n is NewExpression) registerTypeArgumentsAsDependencies(t);
+ });
+
treeElements.forEachConstantNode((Node node, _) {
// Explicitly depend on the backend constants.
ConstantValue value =
« no previous file with comments | « no previous file | pkg/compiler/lib/src/resolution/tree_elements.dart » ('j') | pkg/compiler/lib/src/resolution/tree_elements.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698