dart2js: fix dependency tracking for deferred loading when types are only used

pkg/compiler/lib/src/deferred_load.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library deferred_load;
 
 import 'constants/values.dart' show
     ConstantValue,
     ConstructedConstantValue,
     DeferredConstantValue,
@@ skipping 262 matching lines @@
 
       assert(treeElements != null);
 
       for (Element dependency in treeElements.allElements) {
         if (dependency.isLocal && !dependency.isFunction) continue;
         if (dependency.isErroneous) continue;
         if (dependency.isTypeVariable) continue;
 
         elements.add(dependency);
       }
+
+      treeElements.forEachType((n, t) {
+        registerTypeArgumentsAsDependencies(type) {

[floitsch, 2015/07/17 09:22:25]

Especially for nested functions I want to have a return type (as it's otherwise
hard to see if it's a function call or not).
It also helps when the argument has a type.

Also one new line before and after nested functions (to make them stick out even
more).

[Siggi Cherem (dart-lang), 2015/07/17 15:34:48]

Done.

+          var dependency = type.element;

[floitsch, 2015/07/17 09:22:25]

We usually don't use "var".

[Siggi Cherem (dart-lang), 2015/07/17 15:34:49]

Done.

+          if (dependency == null || dependency.isTypeVariable) return;
+          elements.add(dependency);
+          if (type is GenericType) {
+            type.typeArguments.forEach(registerTypeArgumentsAsDependencies);
+          }
+        }
+        if (n is NewExpression) registerTypeArgumentsAsDependencies(t);
+      });
+
       treeElements.forEachConstantNode((Node node, _) {
         // Explicitly depend on the backend constants.
         ConstantValue value =
             backend.constants.getConstantValueForNode(node, treeElements);
         if (value != null) {
           // TODO(johnniwinther): Assert that all constants have values when
           // these are directly evaluated.
           constants.add(value);
         }
       });
@@ skipping 591 matching lines @@
         _importingLibrary = importingLibrary;
 
   String get importingLibraryName {
     String libraryName = _importingLibrary.getLibraryName();
     return libraryName == ""
       ? "<unnamed>"
       : libraryName;
   }
 
 }