tools/perf/benchmarks/benchmark_unittest.py - Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_unittest.py

Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/benchmark_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_unittest.py b/tools/perf/benchmarks/benchmark_unittest.py

index 9fe848d1a1857b9409b78a6951bd76c785915aaa..d5d039c547f41a0171a0dd143774bd18bdf79a06 100644

--- a/tools/perf/benchmarks/benchmark_unittest.py

+++ b/tools/perf/benchmarks/benchmark_unittest.py

@@ -11,9 +11,9 @@ import unittest

from core import perf_benchmark

from telemetry import benchmark as benchmark_module

-from telemetry.core import discover

from telemetry.internal.browser import browser_options

from telemetry.testing import progress_reporter

+from telemetry.util import classes_util

def _GetPerfDir(*subdirs):

@@ -22,9 +22,8 @@ def _GetPerfDir(*subdirs):

def _GetAllPerfBenchmarks():

- return discover.DiscoverClasses(

- _GetPerfDir('benchmarks'), _GetPerfDir(), benchmark_module.Benchmark,

- index_by_class_name=True).values()

+ return classes_util.DiscoverClasses(

+ _GetPerfDir('benchmarks'), _GetPerfDir(), benchmark_module.Benchmark)

def _BenchmarkOptionsTestGenerator(benchmark):

def testBenchmarkOptions(self): # pylint: disable=W0613

« no previous file with comments | « tools/perf/benchmarks/benchmark_smoke_unittest.py ('k') | tools/perf/benchmarks/skpicture_printer.py » ('j') | no next file with comments »