tools/chrome_proxy/live_tests/pagesets/__init__.py - Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/live_tests/pagesets/init.py

Issue 1244223002: Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py ('k') | tools/perf/benchmarks/benchmark_smoke_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/live_tests/pagesets/__init__.py

diff --git a/tools/chrome_proxy/live_tests/pagesets/__init__.py b/tools/chrome_proxy/live_tests/pagesets/__init__.py

index 45ce4af9df80c564b044b526df9669c00e3a809c..a67d12d383c435d0cbf7b80df98e1b6faef0eb4d 100644

--- a/tools/chrome_proxy/live_tests/pagesets/__init__.py

+++ b/tools/chrome_proxy/live_tests/pagesets/__init__.py

@@ -6,15 +6,14 @@ import inspect

import os

import sys

-from telemetry.core import discover

from telemetry import story

+from telemetry.util import classes_util

# Import all submodules' StorySet classes.

start_dir = os.path.dirname(os.path.abspath(__file__))

top_level_dir = os.path.abspath(os.path.join(start_dir, os.pardir, os.pardir))

base_class = story.StorySet

-for cls in discover.DiscoverClasses(

- start_dir, top_level_dir, base_class).values():

+for cls in classes_util.DiscoverClasses(start_dir, top_level_dir, base_class):

setattr(sys.modules[__name__], cls.__name__, cls)

Unified Diff: tools/chrome_proxy/live_tests/pagesets/__init__.py

Unified Diff: tools/chrome_proxy/live_tests/pagesets/init.py