Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1244123003: The type argument for HTMLCanvasElement toDataURL() api should not be nullable (Closed)

Created:
5 years, 5 months ago by shiva.jm
Modified:
5 years, 5 months ago
Reviewers:
tkent, philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

The type argument for HTMLCanvasElement toDataURL() api should not be nullable As per spec link: https://html.spec.whatwg.org/#the-canvas-element, type argument for HTMLCanvasElement toDataURL() api should not be nullable. These change has no new test to cover, so not added any new tests. Firefox and IE already suppourts these change. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199367

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/html/HTMLCanvasElement.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
shiva.jm
pls have a look.
5 years, 5 months ago (2015-07-23 05:10:52 UTC) #2
philipj_slow
https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js File LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (right): https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js#newcode265 LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js:265: shouldBe("nonNumericPolicy('createCanvasElement().toDataURL(x)')", "'any type allowed'"); Would this have failed before ...
5 years, 5 months ago (2015-07-23 08:02:12 UTC) #3
shiva.jm
updated tests and comments, pls have a look. https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js File LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (right): https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js#newcode265 LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js:265: shouldBe("nonNumericPolicy('createCanvasElement().toDataURL(x)')", ...
5 years, 5 months ago (2015-07-23 08:33:40 UTC) #4
philipj_slow
lgtm
5 years, 5 months ago (2015-07-23 08:35:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244123003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1244123003/40001
5 years, 5 months ago (2015-07-23 08:35:16 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 10:00:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199367

Powered by Google App Engine
This is Rietveld 408576698