The type argument for HTMLCanvasElement toDataURL() api should not be nullable

The type argument for HTMLCanvasElement toDataURL() api should not be nullable

As per spec link:
https://html.spec.whatwg.org/#the-canvas-element,
type argument for HTMLCanvasElement toDataURL() api
should not be nullable. These change has no new test to
cover, so not added any new tests.

Firefox and IE already suppourts these change.

BUG=460722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199367

[shiva.jm, 2015-07-23 05:10:52]

shiva.jm@samsung.com changed reviewers:
+ philipj@opera.com, tkent@chromium.org

[shiva.jm, 2015-07-23 05:10:52]

pls have a look.

[philipj_slow, 2015-07-23 08:02:12]

https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/sc...
File LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
(right):

https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/sc...
LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js:265:
shouldBe("nonNumericPolicy('createCanvasElement().toDataURL(x)')", "'any type
allowed'");
Would this have failed before your change? I don't think that the change is
actually observable, because both the null string and the string 'null' would be
treated the same in HTMLCanvasElement::toEncodingMimeType(). I think it's better
to say that in the description and have no test at all than to have what only
looks like a test for the change.

https://codereview.chromium.org/1244123003/diff/20001/Source/core/html/HTMLCa...
File Source/core/html/HTMLCanvasElement.idl (left):

https://codereview.chromium.org/1244123003/diff/20001/Source/core/html/HTMLCa...
Source/core/html/HTMLCanvasElement.idl:52: // FIXME: type should not be nullable
or have a default value.
It still has a default value null, so leave that part of the FIXME. Actually
fixing that has the same problem as in
https://codereview.chromium.org/1225813003/ and I think you'll find this again
and again.

[shiva.jm, 2015-07-23 08:33:40]

updated tests and comments, pls have a look.

https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/sc...
File LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
(right):

https://codereview.chromium.org/1244123003/diff/20001/LayoutTests/fast/dom/sc...
LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js:265:
shouldBe("nonNumericPolicy('createCanvasElement().toDataURL(x)')", "'any type
allowed'");
On 2015/07/23 08:02:12, philipj wrote:
> Would this have failed before your change? I don't think that the change is
> actually observable, because both the null string and the string 'null' would
be
> treated the same in HTMLCanvasElement::toEncodingMimeType(). I think it's
better
> to say that in the description and have no test at all than to have what only
> looks like a test for the change.

Done.

https://codereview.chromium.org/1244123003/diff/20001/Source/core/html/HTMLCa...
File Source/core/html/HTMLCanvasElement.idl (left):

https://codereview.chromium.org/1244123003/diff/20001/Source/core/html/HTMLCa...
Source/core/html/HTMLCanvasElement.idl:52: // FIXME: type should not be nullable
or have a default value.
On 2015/07/23 08:02:12, philipj wrote:
> It still has a default value null, so leave that part of the FIXME. Actually
> fixing that has the same problem as in
> https://codereview.chromium.org/1225813003/ and I think you'll find this again
> and again.

Done.

[philipj_slow, 2015-07-23 08:35:09]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-07-23 08:35:09]

lgtm

[commit-bot: I haz the power, 2015-07-23 08:35:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1244123003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1244123003/40001

[commit-bot: I haz the power, 2015-07-23 10:00:18]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199367