Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1244093005: Fix SkCanvas::wouldOverwriteEntireSurface() contains test (Closed)

Created:
5 years, 5 months ago by f(malita)
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : test comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244093005/1
5 years, 5 months ago (2015-07-21 21:36:14 UTC) #2
f(malita)
Lots of fun debugging Blink/C2D over this one :)
5 years, 5 months ago (2015-07-21 21:42:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 21:55:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244093005/1
5 years, 5 months ago (2015-07-21 22:40:39 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-21 22:40:40 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 5 months ago (2015-07-22 04:40:06 UTC) #10
robertphillips
lgtm + doc request https://codereview.chromium.org/1244093005/diff/1/tests/ImageTest.cpp File tests/ImageTest.cpp (right): https://codereview.chromium.org/1244093005/diff/1/tests/ImageTest.cpp#newcode133 tests/ImageTest.cpp:133: // Test that a draw ...
5 years, 5 months ago (2015-07-22 12:34:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244093005/20001
5 years, 5 months ago (2015-07-22 12:49:24 UTC) #14
f(malita)
https://codereview.chromium.org/1244093005/diff/1/tests/ImageTest.cpp File tests/ImageTest.cpp (right): https://codereview.chromium.org/1244093005/diff/1/tests/ImageTest.cpp#newcode133 tests/ImageTest.cpp:133: On 2015/07/22 12:34:23, robertphillips wrote: > // Test that ...
5 years, 5 months ago (2015-07-22 12:49:58 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 12:56:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8c0144ccb17220db9d5140ef5ee85d5bc7837513

Powered by Google App Engine
This is Rietveld 408576698