src/core/SkCanvas.cpp - Issue 1244093005: Fix SkCanvas::wouldOverwriteEntireSurface() contains test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 1244093005: Fix SkCanvas::wouldOverwriteEntireSurface() contains test (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: test comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index 570435869b498dbed2bfc7d557084afe66bf2db4..f55ca5e12721626df873c7836e3829e46018f9e4 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -70,7 +70,7 @@ bool SkCanvas::wouldOverwriteEntireSurface(const SkRect* rect, const SkPaint* pa

SkRect devRect;

this->getTotalMatrix().mapRect(&devRect, *rect);

- if (devRect.contains(bounds)) {

+ if (!devRect.contains(bounds)) {

return false;

}

« no previous file with comments | « no previous file | tests/ImageTest.cpp » ('j') | no next file with comments »