Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1244033002: Declare deleted copy constructor and assignment operator of v8::Global to take const parameters. (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Declare deleted copy constructor and assignment operator of v8::Global to take const parameters. This is required in order for Globals to be stored in STL containers. Patch from Aaron Link <aaronlink@google.com>; BUG= Committed: https://crrev.com/7f6012c093ab12ab6e215d9bec8d3eaaa5dd9ce0 Cr-Commit-Position: refs/heads/master@{#29776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/v8.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 5 months ago (2015-07-21 13:30:03 UTC) #2
aaronlink
lgtm
5 years, 5 months ago (2015-07-21 13:55:29 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-21 14:08:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244033002/1
5 years, 5 months ago (2015-07-21 15:15:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 15:53:14 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 15:53:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f6012c093ab12ab6e215d9bec8d3eaaa5dd9ce0
Cr-Commit-Position: refs/heads/master@{#29776}

Powered by Google App Engine
This is Rietveld 408576698