Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: include/v8.h

Issue 1244033002: Declare deleted copy constructor and assignment operator of v8::Global to take const parameters. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 29fac0be778bf97450329c75ad6827b142b726f9..5f4859d339f3e07ba29f3e8fae9fd5eedf3c80d2 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -638,8 +638,8 @@ template <class T> class PersistentBase {
friend class Object;
explicit V8_INLINE PersistentBase(T* val) : val_(val) {}
- PersistentBase(PersistentBase& other) = delete; // NOLINT
- void operator=(PersistentBase&) = delete;
+ PersistentBase(const PersistentBase& other) = delete; // NOLINT
+ void operator=(const PersistentBase&) = delete;
V8_INLINE static T* New(Isolate* isolate, T* that);
T* val_;
@@ -845,8 +845,8 @@ class Global : public PersistentBase<T> {
private:
template <class F>
friend class ReturnValue;
- Global(Global&) = delete;
- void operator=(Global&) = delete;
+ Global(const Global&) = delete;
+ void operator=(const Global&) = delete;
V8_INLINE T* operator*() const { return this->val_; }
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698