Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: chrome/renderer/resources/extensions/platform_app.js

Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make foreach of an array give numbers Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/platform_app.js
diff --git a/chrome/renderer/resources/extensions/platform_app.js b/chrome/renderer/resources/extensions/platform_app.js
index feb35b29f7391d748f5731f09f55234416d3594b..c71c3629ddd5390275e7a8095cec60384dd801e4 100644
--- a/chrome/renderer/resources/extensions/platform_app.js
+++ b/chrome/renderer/resources/extensions/platform_app.js
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+var forEach = require('utils').forEach;
+
/**
* Returns a function that throws a 'not available' exception when called.
*
@@ -27,7 +29,7 @@ function generateDisabledMethodStub(messagePrefix, opt_messageSuffix) {
* @param {Array.<string>} methodNames names of methods to disable.
*/
function disableMethods(object, objectName, methodNames) {
- methodNames.forEach(function(methodName) {
+ forEach(methodNames, function(i, methodName) {
object[methodName] =
generateDisabledMethodStub(objectName + '.' + methodName + '()');
});
@@ -47,7 +49,7 @@ function disableMethods(object, objectName, methodNames) {
* @param {Array.<string>} propertyNames names of properties to disable.
*/
function disableGetters(object, objectName, propertyNames, opt_messageSuffix) {
- propertyNames.forEach(function(propertyName) {
+ forEach(propertyNames, function(i, propertyName) {
var stub = generateDisabledMethodStub(objectName + '.' + propertyName,
opt_messageSuffix);
stub._is_platform_app_disabled_getter = true;

Powered by Google App Engine
This is Rietveld 408576698