[rAC] Allow clickthrough for SuggestionView

[rAC] Allow clickthrough for SuggestionView

Most of the contents in AutofillSuggestionContainer should ignore mouse
clicks and instead let the SectionContainer handle it - the only
exception being the |inputField_| in the SuggestionContainer. This will
allow the suggestion menu to pop up even when the user clicks e.g. on
explanatory text.

Modified hitTest: to ignore all subviews except |inputField_| and
descendants.

BUG=331130
R=rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243673

[Robert Sesek, 2014-01-07 15:10:36]

Is it possible to write a unit test for this using -hitTest: ?

[groby-ooo-7-16, 2014-01-08 01:52:49]

Unit test added - PTAL

[Robert Sesek, 2014-01-08 14:50:18]

LGTM, thanks!

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm
(right):

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm:63:
NSPoint pointOutsideSubviews =
naming: under_scores (also update the comments)

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm:68:
for (id fieldView in [view_ subviews]) {
naming: field_view

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm:93:
ASSERT_NE(editorView, [container_ inputField]);
Generally stick with EXPECT_ unless you need to stop the test from running with
ASSERT_

[groby-ooo-7-16, 2014-01-08 19:20:58]

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm
(right):

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm:63:
NSPoint pointOutsideSubviews =
On 2014/01/08 14:50:19, rsesek wrote:
> naming: under_scores (also update the comments)

Done.

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm:68:
for (id fieldView in [view_ subviews]) {
On 2014/01/08 14:50:19, rsesek wrote:
> naming: field_view

Done.

https://codereview.chromium.org/124383010/diff/70001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm:93:
ASSERT_NE(editorView, [container_ inputField]);
On 2014/01/08 14:50:19, rsesek wrote:
> Generally stick with EXPECT_ unless you need to stop the test from running
with
> ASSERT_

This was intentional - it confirms a precondition for this being a valid test,
not actual behavior of the class under test. (I.e. having a non-child of
editorView after making editorView firstResponder indicates a structural, not a
behavioral failure)

Added comment to clarify.

[commit-bot: I haz the power, 2014-01-08 19:23:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/124383010/160001

[commit-bot: I haz the power, 2014-01-08 22:23:51]

Change committed as 243673