[rAC] Allow clickthrough for SuggestionView

chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h"
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_textfield.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "ui/base/test/ui_cocoa_test_helper.h"
 
 namespace {
 
 class AutofillSuggestionContainerTest : public ui::CocoaTest {
  public:
   virtual void SetUp() {
     CocoaTest::SetUp();
     container_.reset([[AutofillSuggestionContainer alloc] init]);
     [[test_window() contentView] addSubview:[container_ view]];
+    view_ = [container_ view];
   }
 
  protected:
   base::scoped_nsobject<AutofillSuggestionContainer> container_;
+  NSView* view_;
 };
 
 }  // namespace
 
 TEST_VIEW(AutofillSuggestionContainerTest, [container_ view])
 
 TEST_F(AutofillSuggestionContainerTest, HasSubviews) {
   ASSERT_EQ(3U, [[[container_ view] subviews] count]);
 
   bool has_text_view = false;
   bool has_edit_field = false;
 
   // Ignore |spacer_| NSBox in this test.
   for (id view in [[container_ view] subviews]) {
     if ([view isKindOfClass:[AutofillTextField class]]) {
       has_edit_field = true;
     } else if ([view isKindOfClass:[NSTextView class]]) {
       has_text_view = true;
     }
   }
 
   EXPECT_TRUE(has_text_view);
   EXPECT_TRUE(has_edit_field);
 }
+
+// Test that mouse events outside the input field are ignored.
+TEST_F(AutofillSuggestionContainerTest, HitTestInputField) {
+ base::scoped_nsobject<NSImage> icon(
+      [[NSImage alloc] initWithSize:NSMakeSize(16, 16)]);
+  [container_ setSuggestionWithVerticallyCompactText:@"suggest"
+                             horizontallyCompactText:@"suggest"
+                                                icon:nil
+                                            maxWidth:200];
+  [container_ showInputField:@"input" withIcon:icon];
+  [view_ setFrameSize:[container_ preferredSize]];
+  [container_ performLayout];
+
+  // Point not touching any subviews, in |view_|'s coordinate system.
+  NSPoint pointOutsideSubviews =

[Robert Sesek, 2014/01/08 14:50:19]

naming: under_scores (also update the comments)

[groby-ooo-7-16, 2014/01/08 19:20:58]

Done.

+      NSMakePoint(NSMinX([view_ bounds]), NSMaxY([view_ bounds]) - 1);
+  NSPoint pointInsideTextView = NSZeroPoint;
+
+  // hitTests on all inputs should be false, except for the inputField.
+  for (id fieldView in [view_ subviews]) {

[Robert Sesek, 2014/01/08 14:50:19]

naming: field_view

[groby-ooo-7-16, 2014/01/08 19:20:58]

Done.

+    // Ensure |pointOutsideSubviews| really is outside subviews.
+    ASSERT_FALSE([fieldView hitTest:pointOutsideSubviews]);
+
+    // Compute center of |fieldView| in |view_|'s parent coordinate system.
+    NSPoint point =
+        [view_ convertPoint:NSMakePoint(NSMidX([fieldView frame]),
+                                        NSMidY([fieldView frame]))
+                     toView:[view_ superview]];
+    if (fieldView == [container_ inputField]) {
+      pointInsideTextView = point;
+      EXPECT_TRUE([view_ hitTest:point]);
+    } else {
+      EXPECT_FALSE([view_ hitTest:point]);
+    }
+  }
+
+  // Mouse events directly on the main view should be ignored.
+  EXPECT_FALSE([view_ hitTest:
+      [view_ convertPoint:pointOutsideSubviews
+                   toView:[view_ superview]]]);
+
+  // Mouse events on the text view's editor should propagate.
+  [[view_ window] makeFirstResponder:[container_ inputField]];
+  NSView* editorView = [view_ hitTest:pointInsideTextView];
+  ASSERT_NE(editorView, [container_ inputField]);

[Robert Sesek, 2014/01/08 14:50:19]

Generally stick with EXPECT_ unless you need to stop the test from running with
ASSERT_

[groby-ooo-7-16, 2014/01/08 19:20:58]

This was intentional - it confirms a precondition for this being a valid test,
not actual behavior of the class under test. (I.e. having a non-child of
editorView after making editorView firstResponder indicates a structural, not a
behavioral failure)

Added comment to clarify.

+  ASSERT_TRUE([editorView isDescendantOf:[container_ inputField]]);
+  EXPECT_TRUE(editorView);
+}