native_client_sdk/src/build_tools/build_sdk.py - Issue 1243823002: [NaCl SDK] Second phase of enable glibc arm toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 1243823002: [NaCl SDK] Second phase of enable glibc arm toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reenable_irtext

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/build_tools/build_sdk.py

diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py

index 0d905c3919319f2cbae6488e3dd3dc5a0e665c8b..9169c29555eecc4d428f8670e0a65347b389f521 100755

--- a/native_client_sdk/src/build_tools/build_sdk.py

+++ b/native_client_sdk/src/build_tools/build_sdk.py

@@ -445,9 +445,6 @@ def GypNinjaInstall(pepperdir, toolchains):

for tc in toolchains:

if tc in ('host', 'clang-newlib'):

continue

- # TODO(sbc): remove this once untrusted.gypi can build arm glibc targets

- elif tc == 'arm_glibc':

- continue

elif tc == 'pnacl':

xarches = (None, 'ia32', 'x64', 'arm')

elif tc in ('x86_glibc', 'x86_newlib'):

« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/sdk_files.list » ('j') | no next file with comments »