Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1243733002: Remove iOS specific code from ChromeRLZTrackerDelegate. (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@rlz-tracker-delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove iOS specific code from ChromeRLZTrackerDelegate. iOS has its own implementation of RLZTrackerDelegate in //ios/chrome/rlz so remove code protected by OS_IOS in chrome_rlz_tracker_delagate.{h,cc}. Fix #include. BUG=511570 Committed: https://crrev.com/bd4c75c67e6830740a023353c729e722c41e59ef Cr-Commit-Position: refs/heads/master@{#339850}

Patch Set 1 #

Patch Set 2 : Fix overzealous #include removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M chrome/browser/rlz/chrome_rlz_tracker_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/rlz/chrome_rlz_tracker_delegate.cc View 1 7 chunks +3 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
5 years, 5 months ago (2015-07-20 17:30:58 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 5 months ago (2015-07-21 16:32:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243733002/20001
5 years, 5 months ago (2015-07-22 08:59:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 09:06:26 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 09:07:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd4c75c67e6830740a023353c729e722c41e59ef
Cr-Commit-Position: refs/heads/master@{#339850}

Powered by Google App Engine
This is Rietveld 408576698