Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1242373002: Implements RLZTrackerDelegate on iOS. (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@omnibox-events-relay
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements RLZTrackerDelegate on iOS. BUG=511570 Committed: https://crrev.com/8ff2e5ea76f4aed908188f0368ccb12d290236a7 Cr-Commit-Position: refs/heads/master@{#339676}

Patch Set 1 : xxx #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -0 lines) Patch
M ios/chrome/browser/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/pref_names.cc View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h View 1 chunk +57 lines, -0 lines 0 comments Download
A ios/chrome/browser/rlz/rlz_tracker_delegate_impl.cc View 1 1 chunk +137 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1245683002 Patch 20001

Dependent Patchsets:

Issue 1243733002 Patch 1
Issue 1243733002 Patch 20001

Messages

Total messages: 10 (4 generated)
sdefresne
PTAL
5 years, 5 months ago (2015-07-20 16:33:10 UTC) #2
droger
lgtm
5 years, 5 months ago (2015-07-20 16:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242373002/40001
5 years, 5 months ago (2015-07-21 17:04:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 5 months ago (2015-07-21 17:17:50 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8ff2e5ea76f4aed908188f0368ccb12d290236a7 Cr-Commit-Position: refs/heads/master@{#339676}
5 years, 5 months ago (2015-07-21 17:19:28 UTC) #9
sdefresne
5 years, 5 months ago (2015-07-21 17:27:29 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1250693003/ by sdefresne@chromium.org.

The reason for reverting is: Landed wrong patchset..

Powered by Google App Engine
This is Rietveld 408576698