Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3932)

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

Issue 124373004: Replace some VLOG(1) with DVLOG(1). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
index 7fc3688474616ec0ace7992117585edc045d75ea..34732547be10e4afafd1ca09bbfa9da7007e8555 100644
--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
@@ -25,8 +25,6 @@
#include "ui/gfx/color_utils.h"
#include "ui/native_theme/native_theme.h"
-// TODO(dconnelly): change VLOG to DVLOG (crbug.com/240195)
-
namespace {
const int kHistoryEntriesBeforeNewProfilePrompt = 10;
@@ -43,7 +41,7 @@ class HasTypedURLsTask : public history::HistoryDBTask {
history::URLRows rows;
backend->GetAllTypedURLs(&rows);
if (!rows.empty()) {
- VLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
+ DVLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
<< rows.size() << " typed URLs";
Andrew T Wilson (Slow) 2014/01/07 14:58:55 nit: fix indent on line 45 also.
dconnelly 2014/01/07 15:07:15 Done.
has_typed_urls_ = true;
}
@@ -64,7 +62,7 @@ bool HasBookmarks(Profile* profile) {
BookmarkModel* bookmarks = BookmarkModelFactory::GetForProfile(profile);
bool has_bookmarks = bookmarks && bookmarks->HasBookmarks();
if (has_bookmarks)
- VLOG(1) << "ProfileSigninConfirmationHelper: profile contains bookmarks";
+ DVLOG(1) << "ProfileSigninConfirmationHelper: profile contains bookmarks";
return has_bookmarks;
}
@@ -127,7 +125,7 @@ void ProfileSigninConfirmationHelper::OnHistoryQueryResults(
results->Swap(&owned_results);
bool too_much_history = owned_results.size() >= max_entries;
if (too_much_history) {
- VLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
+ DVLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
<< owned_results.size() << " history entries";
Andrew T Wilson (Slow) 2014/01/07 14:58:55 nit: fix indent on line 129
dconnelly 2014/01/07 15:07:15 Done.
}
ReturnResult(too_much_history);
@@ -192,7 +190,7 @@ SkColor GetSigninConfirmationPromptBarColor(SkAlpha alpha) {
bool HasBeenShutdown(Profile* profile) {
bool has_been_shutdown = !profile->IsNewProfile();
if (has_been_shutdown)
- VLOG(1) << "ProfileSigninConfirmationHelper: profile is not new";
+ DVLOG(1) << "ProfileSigninConfirmationHelper: profile is not new";
return has_been_shutdown;
}
@@ -210,7 +208,7 @@ bool HasSyncedExtensions(Profile* profile) {
if (extensions::sync_helper::IsSyncable(iter->get()) &&
(*iter)->id() != extension_misc::kWebStoreAppId &&
(*iter)->id() != extension_misc::kChromeAppId) {
- VLOG(1) << "ProfileSigninConfirmationHelper: "
+ DVLOG(1) << "ProfileSigninConfirmationHelper: "
<< "profile contains a synced extension: " << (*iter)->id();
Andrew T Wilson (Slow) 2014/01/07 14:58:55 nit: fix indent on line 212
dconnelly 2014/01/07 15:07:15 Done.
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698