Replace some VLOG(1) with DVLOG(1).

chrome/browser/ui/sync/profile_signin_confirmation_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/profile_signin_confirmation_helper.h"
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/common/cancelable_request.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/history/history_backend.h"
 #include "chrome/browser/history/history_db_task.h"
 #include "chrome/browser/history/history_service.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/history/history_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/sync_helper.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/native_theme/native_theme.h"
 
-// TODO(dconnelly): change VLOG to DVLOG (crbug.com/240195)
-
 namespace {
 
 const int kHistoryEntriesBeforeNewProfilePrompt = 10;
 
 // Determines whether a profile has any typed URLs in its history.
 class HasTypedURLsTask : public history::HistoryDBTask {
  public:
   HasTypedURLsTask(const base::Callback<void(bool)>& cb)
       : has_typed_urls_(false), cb_(cb) {
   }
 
   virtual bool RunOnDBThread(history::HistoryBackend* backend,
                              history::HistoryDatabase* db) OVERRIDE {
     history::URLRows rows;
     backend->GetAllTypedURLs(&rows);
     if (!rows.empty()) {
-      VLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
+      DVLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
               << rows.size() << " typed URLs";

[Andrew T Wilson (Slow), 2014/01/07 14:58:55]

nit: fix indent on line 45 also.

[dconnelly, 2014/01/07 15:07:15]

Done.

       has_typed_urls_ = true;
     }
     return true;
   }
 
   virtual void DoneRunOnMainThread() OVERRIDE {
     cb_.Run(has_typed_urls_);
   }
 
  private:
   virtual ~HasTypedURLsTask() {}
   bool has_typed_urls_;
   base::Callback<void(bool)> cb_;
 };
 
 bool HasBookmarks(Profile* profile) {
   BookmarkModel* bookmarks = BookmarkModelFactory::GetForProfile(profile);
   bool has_bookmarks = bookmarks && bookmarks->HasBookmarks();
   if (has_bookmarks)
-    VLOG(1) << "ProfileSigninConfirmationHelper: profile contains bookmarks";
+    DVLOG(1) << "ProfileSigninConfirmationHelper: profile contains bookmarks";
   return has_bookmarks;
 }
 
 // Helper functions for Chrome profile signin.
 class ProfileSigninConfirmationHelper
     : public base::RefCounted<ProfileSigninConfirmationHelper> {
  public:
   ProfileSigninConfirmationHelper(
       Profile* profile,
       const base::Callback<void(bool)>& return_result);
@@ skipping 42 matching lines @@
 }
 
 void ProfileSigninConfirmationHelper::OnHistoryQueryResults(
     size_t max_entries,
     CancelableRequestProvider::Handle handle,
     history::QueryResults* results) {
   history::QueryResults owned_results;
   results->Swap(&owned_results);
   bool too_much_history = owned_results.size() >= max_entries;
   if (too_much_history) {
-    VLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
+    DVLOG(1) << "ProfileSigninConfirmationHelper: profile contains "
             << owned_results.size() << " history entries";

[Andrew T Wilson (Slow), 2014/01/07 14:58:55]

nit: fix indent on line 129

[dconnelly, 2014/01/07 15:07:15]

Done.

   }
   ReturnResult(too_much_history);
 }
 
 void ProfileSigninConfirmationHelper::CheckHasHistory(int max_entries) {
   HistoryService* service =
       HistoryServiceFactory::GetForProfileWithoutCreating(profile_);
   if (!service) {
     ReturnResult(false);
     return;
@@ skipping 43 matching lines @@
 SkColor GetSigninConfirmationPromptBarColor(SkAlpha alpha) {
   static const SkColor kBackgroundColor =
       ui::NativeTheme::instance()->GetSystemColor(
           ui::NativeTheme::kColorId_DialogBackground);
   return color_utils::BlendTowardOppositeLuminance(kBackgroundColor, alpha);
 }
 
 bool HasBeenShutdown(Profile* profile) {
   bool has_been_shutdown = !profile->IsNewProfile();
   if (has_been_shutdown)
-    VLOG(1) << "ProfileSigninConfirmationHelper: profile is not new";
+    DVLOG(1) << "ProfileSigninConfirmationHelper: profile is not new";
   return has_been_shutdown;
 }
 
 bool HasSyncedExtensions(Profile* profile) {
   extensions::ExtensionSystem* system =
       extensions::ExtensionSystem::Get(profile);
   if (system && system->extension_service()) {
     const extensions::ExtensionSet* extensions =
         system->extension_service()->extensions();
     for (extensions::ExtensionSet::const_iterator iter = extensions->begin();
          iter != extensions->end(); ++iter) {
       // The webstore is synced so that it stays put on the new tab
       // page, but since it's installed by default we don't want to
       // consider it when determining if the profile is dirty.
       if (extensions::sync_helper::IsSyncable(iter->get()) &&
           (*iter)->id() != extension_misc::kWebStoreAppId &&
           (*iter)->id() != extension_misc::kChromeAppId) {
-        VLOG(1) << "ProfileSigninConfirmationHelper: "
+        DVLOG(1) << "ProfileSigninConfirmationHelper: "
                 << "profile contains a synced extension: " << (*iter)->id();

[Andrew T Wilson (Slow), 2014/01/07 14:58:55]

nit: fix indent on line 212

[dconnelly, 2014/01/07 15:07:15]

Done.

         return true;
       }
     }
   }
   return false;
 }
 
 void CheckShouldPromptForNewProfile(
     Profile* profile,
     const base::Callback<void(bool)>& return_result) {
   if (HasBeenShutdown(profile) ||
       HasBookmarks(profile) ||
       HasSyncedExtensions(profile)) {
     return_result.Run(true);
     return;
   }
   // Fire asynchronous queries for profile data.
   scoped_refptr<ProfileSigninConfirmationHelper> helper =
       new ProfileSigninConfirmationHelper(profile, return_result);
   const int requests = 2;
   helper->set_pending_requests(requests);
   helper->CheckHasHistory(kHistoryEntriesBeforeNewProfilePrompt);
   helper->CheckHasTypedURLs();
 }
 
 }  // namespace ui