Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 124373004: Replace some VLOG(1) with DVLOG(1). (Closed)

Created:
6 years, 11 months ago by dconnelly
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Replace some VLOG(1) with DVLOG(1). BUG=240195 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243362

Patch Set 1 #

Total comments: 6

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/browser/ui/sync/profile_signin_confirmation_helper.cc View 1 6 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dconnelly
6 years, 11 months ago (2014-01-07 10:45:33 UTC) #1
Andrew T Wilson (Slow)
lgtm with nits https://codereview.chromium.org/124373004/diff/1/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc File chrome/browser/ui/sync/profile_signin_confirmation_helper.cc (right): https://codereview.chromium.org/124373004/diff/1/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc#newcode45 chrome/browser/ui/sync/profile_signin_confirmation_helper.cc:45: << rows.size() << " typed URLs"; ...
6 years, 11 months ago (2014-01-07 14:58:55 UTC) #2
dconnelly
https://codereview.chromium.org/124373004/diff/1/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc File chrome/browser/ui/sync/profile_signin_confirmation_helper.cc (right): https://codereview.chromium.org/124373004/diff/1/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc#newcode45 chrome/browser/ui/sync/profile_signin_confirmation_helper.cc:45: << rows.size() << " typed URLs"; On 2014/01/07 14:58:55, ...
6 years, 11 months ago (2014-01-07 15:07:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/124373004/50001
6 years, 11 months ago (2014-01-07 15:07:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/124373004/50001
6 years, 11 months ago (2014-01-07 15:31:00 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 19:38:46 UTC) #6
Message was sent while issue was closed.
Change committed as 243362

Powered by Google App Engine
This is Rietveld 408576698