Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1243323002: Refactor a bit. (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix dummy package godoc #

Patch Set 3 : internal error type #

Patch Set 4 : fix comments from 1236043006 #

Patch Set 5 : fix golint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2868 lines, -15467 lines) Patch
D context.go View 1 chunk +0 lines, -20 lines 0 comments Download
D dummy/doc.go View 1 chunk +0 lines, -20 lines 0 comments Download
D dummy/dummy.go View 1 chunk +0 lines, -189 lines 0 comments Download
D dummy/dummy_test.go View 1 chunk +0 lines, -77 lines 0 comments Download
M filters/count/count_test.go View 9 chunks +23 lines, -20 lines 0 comments Download
M filters/count/gi.go View 2 chunks +28 lines, -28 lines 0 comments Download
M filters/count/mc.go View 4 chunks +15 lines, -15 lines 0 comments Download
M filters/count/rds.go View 3 chunks +17 lines, -17 lines 0 comments Download
M filters/count/tq.go View 4 chunks +12 lines, -12 lines 0 comments Download
M filters/featureBreaker/featurebreaker_test.go View 4 chunks +6 lines, -6 lines 0 comments Download
M filters/featureBreaker/gi.go View 1 chunk +18 lines, -18 lines 0 comments Download
M filters/featureBreaker/mc.go View 2 chunks +27 lines, -27 lines 0 comments Download
M filters/featureBreaker/rds.go View 2 chunks +23 lines, -23 lines 0 comments Download
M filters/featureBreaker/tq.go View 7 chunks +12 lines, -12 lines 0 comments Download
D globalinfo.go View 1 chunk +0 lines, -98 lines 0 comments Download
D helper/datastore.go View 1 chunk +0 lines, -35 lines 0 comments Download
D helper/datastore_impl.go View 1 chunk +0 lines, -574 lines 0 comments Download
D helper/datastore_key.go View 1 chunk +0 lines, -236 lines 0 comments Download
D helper/datastore_key_test.go View 1 chunk +0 lines, -245 lines 0 comments Download
D helper/datastore_test.go View 1 chunk +0 lines, -1718 lines 0 comments Download
D helper/generic_key.go View 1 chunk +0 lines, -107 lines 0 comments Download
D helper/internal/protos/datastore/README.md View 1 chunk +0 lines, -5 lines 0 comments Download
D helper/internal/protos/datastore/datastore_v3.proto View 1 chunk +0 lines, -541 lines 0 comments Download
D helper/internal/protos/datastore/datastore_v3.pb.go View 1 chunk +0 lines, -2776 lines 0 comments Download
D helper/serialize.go View 1 chunk +0 lines, -343 lines 0 comments Download
D helper/serialize_test.go View 1 chunk +0 lines, -354 lines 0 comments Download
A + impl/dummy/doc.go View 1 chunk +4 lines, -5 lines 0 comments Download
A impl/dummy/dummy.go View 1 1 chunk +173 lines, -0 lines 0 comments Download
A + impl/dummy/dummy_test.go View 1 2 chunks +24 lines, -29 lines 0 comments Download
A + impl/memory/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + impl/memory/context.go View 5 chunks +5 lines, -5 lines 0 comments Download
A + impl/memory/doc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + impl/memory/gkvlite_utils.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + impl/memory/gkvlite_utils_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + impl/memory/globalinfo.go View 3 chunks +6 lines, -6 lines 0 comments Download
A + impl/memory/memcache.go View 1 11 chunks +23 lines, -24 lines 0 comments Download
A + impl/memory/memcache_test.go View 7 chunks +9 lines, -9 lines 0 comments Download
A + impl/memory/plist.go View 9 chunks +11 lines, -13 lines 0 comments Download
A + impl/memory/plist_test.go View 14 chunks +62 lines, -62 lines 0 comments Download
A + impl/memory/raw_datastore.go View 7 chunks +35 lines, -36 lines 0 comments Download
A + impl/memory/raw_datastore_data.go View 22 chunks +75 lines, -76 lines 0 comments Download
A + impl/memory/raw_datastore_query.go View 11 chunks +22 lines, -23 lines 0 comments Download
A + impl/memory/raw_datastore_test.go View 23 chunks +45 lines, -46 lines 0 comments Download
A + impl/memory/taskqueue.go View 1 14 chunks +34 lines, -32 lines 0 comments Download
A + impl/memory/taskqueue_data.go View 9 chunks +27 lines, -26 lines 0 comments Download
A + impl/memory/taskqueue_test.go View 16 chunks +58 lines, -56 lines 0 comments Download
A + impl/memory/testing_utils_test.go View 3 chunks +11 lines, -12 lines 0 comments Download
A + impl/prod/context.go View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
A + impl/prod/datastore_key.go View 6 chunks +11 lines, -12 lines 0 comments Download
A + impl/prod/doc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + impl/prod/info.go View 3 chunks +5 lines, -5 lines 0 comments Download
A + impl/prod/memcache.go View 7 chunks +27 lines, -26 lines 0 comments Download
A + impl/prod/raw_datastore.go View 7 chunks +32 lines, -31 lines 0 comments Download
A + impl/prod/raw_datastore_type_converter.go View 2 chunks +15 lines, -14 lines 0 comments Download
A + impl/prod/taskqueue.go View 1 2 3 4 8 chunks +26 lines, -25 lines 0 comments Download
D mathrand.go View 1 chunk +0 lines, -45 lines 0 comments Download
D mathrand_test.go View 1 chunk +0 lines, -48 lines 0 comments Download
D memcache.go View 1 chunk +0 lines, -117 lines 0 comments Download
D memory/README.md View 1 chunk +0 lines, -114 lines 0 comments Download
D memory/context.go View 1 chunk +0 lines, -160 lines 0 comments Download
D memory/doc.go View 1 chunk +0 lines, -7 lines 0 comments Download
D memory/gkvlite_utils.go View 1 chunk +0 lines, -148 lines 0 comments Download
D memory/gkvlite_utils_test.go View 1 chunk +0 lines, -128 lines 0 comments Download
D memory/globalinfo.go View 1 chunk +0 lines, -54 lines 0 comments Download
D memory/memcache.go View 1 chunk +0 lines, -203 lines 0 comments Download
D memory/memcache_test.go View 1 chunk +0 lines, -182 lines 0 comments Download
D memory/plist.go View 1 chunk +0 lines, -291 lines 0 comments Download
D memory/plist_test.go View 1 chunk +0 lines, -391 lines 0 comments Download
D memory/raw_datastore.go View 1 chunk +0 lines, -185 lines 0 comments Download
D memory/raw_datastore_data.go View 1 chunk +0 lines, -517 lines 0 comments Download
D memory/raw_datastore_query.go View 1 chunk +0 lines, -593 lines 0 comments Download
D memory/raw_datastore_test.go View 1 chunk +0 lines, -597 lines 0 comments Download
D memory/taskqueue.go View 1 chunk +0 lines, -254 lines 0 comments Download
D memory/taskqueue_data.go View 1 chunk +0 lines, -258 lines 0 comments Download
D memory/taskqueue_test.go View 1 chunk +0 lines, -411 lines 0 comments Download
D memory/testing_utils_test.go View 1 chunk +0 lines, -108 lines 0 comments Download
D prod/context.go View 1 chunk +0 lines, -23 lines 0 comments Download
D prod/datastore_key.go View 1 chunk +0 lines, -80 lines 0 comments Download
D prod/doc.go View 1 chunk +0 lines, -7 lines 0 comments Download
D prod/globalinfo.go View 1 chunk +0 lines, -83 lines 0 comments Download
D prod/memcache.go View 1 chunk +0 lines, -155 lines 0 comments Download
D prod/raw_datastore.go View 1 chunk +0 lines, -144 lines 0 comments Download
D prod/raw_datastore_type_converter.go View 1 chunk +0 lines, -78 lines 0 comments Download
D prod/taskqueue.go View 1 chunk +0 lines, -149 lines 0 comments Download
D properties.go View 1 chunk +0 lines, -449 lines 0 comments Download
D properties_test.go View 1 chunk +0 lines, -180 lines 0 comments Download
D raw_datastore.go View 1 chunk +0 lines, -155 lines 0 comments Download
A service/blobstore/types.go View 1 chunk +16 lines, -0 lines 0 comments Download
A service/info/context.go View 1 chunk +79 lines, -0 lines 0 comments Download
A service/info/interface.go View 1 chunk +35 lines, -0 lines 0 comments Download
A service/info/types.go View 1 chunk +11 lines, -0 lines 0 comments Download
A service/memcache/context.go View 1 chunk +79 lines, -0 lines 0 comments Download
A service/memcache/errors.go View 1 chunk +23 lines, -0 lines 0 comments Download
A service/memcache/interface.go View 1 chunk +29 lines, -0 lines 0 comments Download
A service/memcache/types.go View 1 chunk +42 lines, -0 lines 0 comments Download
A service/rawdatastore/context.go View 1 chunk +79 lines, -0 lines 0 comments Download
A service/rawdatastore/context_test.go View 1 chunk +52 lines, -0 lines 0 comments Download
A + service/rawdatastore/datastore.go View 1 chunk +4 lines, -8 lines 0 comments Download
A + service/rawdatastore/datastore_impl.go View 24 chunks +35 lines, -46 lines 0 comments Download
A + service/rawdatastore/datastore_key.go View 12 chunks +37 lines, -38 lines 0 comments Download
A + service/rawdatastore/datastore_key_test.go View 6 chunks +62 lines, -63 lines 0 comments Download
A + service/rawdatastore/datastore_test.go View 42 chunks +110 lines, -110 lines 0 comments Download
A service/rawdatastore/errors.go View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A service/rawdatastore/generic_key.go View 1 chunk +105 lines, -0 lines 0 comments Download
A service/rawdatastore/interface.go View 1 chunk +86 lines, -0 lines 0 comments Download
A + service/rawdatastore/internal/protos/datastore/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + service/rawdatastore/internal/protos/datastore/datastore_v3.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + service/rawdatastore/internal/protos/datastore/datastore_v3.pb.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A service/rawdatastore/invertible.go View 1 2 3 4 1 chunk +115 lines, -0 lines 0 comments Download
A service/rawdatastore/invertible_test.go View 1 2 3 1 chunk +89 lines, -0 lines 0 comments Download
A + service/rawdatastore/properties.go View 1 2 3 4 14 chunks +141 lines, -151 lines 0 comments Download
A + service/rawdatastore/properties_test.go View 5 chunks +44 lines, -43 lines 0 comments Download
A service/rawdatastore/reflect.go View 1 chunk +27 lines, -0 lines 0 comments Download
A service/rawdatastore/serialize.go View 1 2 1 chunk +377 lines, -0 lines 0 comments Download
A + service/rawdatastore/serialize_test.go View 8 chunks +67 lines, -97 lines 0 comments Download
A service/rawdatastore/types.go View 1 chunk +39 lines, -0 lines 0 comments Download
A service/taskqueue/context.go View 1 chunk +79 lines, -0 lines 0 comments Download
A + service/taskqueue/errors.go View 1 chunk +7 lines, -3 lines 0 comments Download
A service/taskqueue/interface.go View 1 chunk +22 lines, -0 lines 0 comments Download
A + service/taskqueue/testable.go View 1 chunk +5 lines, -5 lines 0 comments Download
A + service/taskqueue/types.go View 4 chunks +9 lines, -74 lines 0 comments Download
D service_test.go View 1 chunk +0 lines, -101 lines 0 comments Download
D taskqueue.go View 1 chunk +0 lines, -89 lines 0 comments Download
D taskqueue_testable.go View 1 chunk +0 lines, -20 lines 0 comments Download
M upstream_errors.go View 1 chunk +0 lines, -53 lines 0 comments Download
D upstream_types.go View 1 chunk +0 lines, -164 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
iannucci
5 years, 5 months ago (2015-07-22 05:14:31 UTC) #1
iannucci
Committed patchset #5 (id:80001) manually as 335f4c3d4ed4c653645fc5bea35660bbdb64ed7c (presubmit successful).
5 years, 5 months ago (2015-07-23 01:15:52 UTC) #2
Erik Staab (Google)
On 2015/07/23 01:15:52, iannucci wrote: > Committed patchset #5 (id:80001) manually as > 335f4c3d4ed4c653645fc5bea35660bbdb64ed7c (presubmit ...
5 years, 5 months ago (2015-07-23 04:43:58 UTC) #3
Erik Staab (Google)
5 years, 5 months ago (2015-07-23 04:44:27 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698