Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: filters/featureBreaker/mc.go

Issue 1243323002: Refactor a bit. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: fix golint Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « filters/featureBreaker/gi.go ('k') | filters/featureBreaker/rds.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package featureBreaker 5 package featureBreaker
6 6
7 import ( 7 import (
8 "golang.org/x/net/context" 8 "golang.org/x/net/context"
9 9
10 » "github.com/luci/gae" 10 » mc "github.com/luci/gae/service/memcache"
11 ) 11 )
12 12
13 type mcState struct { 13 type mcState struct {
14 *state 14 *state
15 15
16 » gae.Memcache 16 » mc.Interface
17 } 17 }
18 18
19 func (m *mcState) Get(key string) (ret gae.MCItem, err error) { 19 func (m *mcState) Get(key string) (ret mc.Item, err error) {
20 err = m.run(func() (err error) { 20 err = m.run(func() (err error) {
21 » » ret, err = m.Memcache.Get(key) 21 » » ret, err = m.Interface.Get(key)
22 return 22 return
23 }) 23 })
24 return 24 return
25 } 25 }
26 26
27 func (m *mcState) GetMulti(keys []string) (ret map[string]gae.MCItem, err error) { 27 func (m *mcState) GetMulti(keys []string) (ret map[string]mc.Item, err error) {
28 err = m.run(func() (err error) { 28 err = m.run(func() (err error) {
29 » » ret, err = m.Memcache.GetMulti(keys) 29 » » ret, err = m.Interface.GetMulti(keys)
30 return 30 return
31 }) 31 })
32 return 32 return
33 } 33 }
34 34
35 func (m *mcState) Add(item gae.MCItem) error { 35 func (m *mcState) Add(item mc.Item) error {
36 » return m.run(func() error { return m.Memcache.Add(item) }) 36 » return m.run(func() error { return m.Interface.Add(item) })
37 } 37 }
38 38
39 func (m *mcState) Set(item gae.MCItem) error { 39 func (m *mcState) Set(item mc.Item) error {
40 » return m.run(func() error { return m.Memcache.Set(item) }) 40 » return m.run(func() error { return m.Interface.Set(item) })
41 } 41 }
42 42
43 func (m *mcState) Delete(key string) error { 43 func (m *mcState) Delete(key string) error {
44 » return m.run(func() error { return m.Memcache.Delete(key) }) 44 » return m.run(func() error { return m.Interface.Delete(key) })
45 } 45 }
46 46
47 func (m *mcState) CompareAndSwap(item gae.MCItem) error { 47 func (m *mcState) CompareAndSwap(item mc.Item) error {
48 » return m.run(func() error { return m.Memcache.CompareAndSwap(item) }) 48 » return m.run(func() error { return m.Interface.CompareAndSwap(item) })
49 } 49 }
50 50
51 func (m *mcState) AddMulti(items []gae.MCItem) error { 51 func (m *mcState) AddMulti(items []mc.Item) error {
52 » return m.run(func() error { return m.Memcache.AddMulti(items) }) 52 » return m.run(func() error { return m.Interface.AddMulti(items) })
53 } 53 }
54 54
55 func (m *mcState) SetMulti(items []gae.MCItem) error { 55 func (m *mcState) SetMulti(items []mc.Item) error {
56 » return m.run(func() error { return m.Memcache.SetMulti(items) }) 56 » return m.run(func() error { return m.Interface.SetMulti(items) })
57 } 57 }
58 58
59 func (m *mcState) DeleteMulti(keys []string) error { 59 func (m *mcState) DeleteMulti(keys []string) error {
60 » return m.run(func() error { return m.Memcache.DeleteMulti(keys) }) 60 » return m.run(func() error { return m.Interface.DeleteMulti(keys) })
61 } 61 }
62 62
63 func (m *mcState) Flush() error { 63 func (m *mcState) Flush() error {
64 » return m.run(func() error { return m.Memcache.Flush() }) 64 » return m.run(func() error { return m.Interface.Flush() })
65 } 65 }
66 66
67 func (m *mcState) CompareAndSwapMulti(items []gae.MCItem) error { 67 func (m *mcState) CompareAndSwapMulti(items []mc.Item) error {
68 » return m.run(func() error { return m.Memcache.CompareAndSwapMulti(items) }) 68 » return m.run(func() error { return m.Interface.CompareAndSwapMulti(items ) })
69 } 69 }
70 70
71 func (m *mcState) Increment(key string, delta int64, initialValue uint64) (newVa lue uint64, err error) { 71 func (m *mcState) Increment(key string, delta int64, initialValue uint64) (newVa lue uint64, err error) {
72 err = m.run(func() (err error) { 72 err = m.run(func() (err error) {
73 » » newValue, err = m.Memcache.Increment(key, delta, initialValue) 73 » » newValue, err = m.Interface.Increment(key, delta, initialValue)
74 return 74 return
75 }) 75 })
76 return 76 return
77 } 77 }
78 78
79 func (m *mcState) IncrementExisting(key string, delta int64) (newValue uint64, e rr error) { 79 func (m *mcState) IncrementExisting(key string, delta int64) (newValue uint64, e rr error) {
80 err = m.run(func() (err error) { 80 err = m.run(func() (err error) {
81 » » newValue, err = m.Memcache.IncrementExisting(key, delta) 81 » » newValue, err = m.Interface.IncrementExisting(key, delta)
82 return 82 return
83 }) 83 })
84 return 84 return
85 } 85 }
86 86
87 func (m *mcState) Stats() (ret *gae.MCStatistics, err error) { 87 func (m *mcState) Stats() (ret *mc.Statistics, err error) {
88 err = m.run(func() (err error) { 88 err = m.run(func() (err error) {
89 » » ret, err = m.Memcache.Stats() 89 » » ret, err = m.Interface.Stats()
90 return 90 return
91 }) 91 })
92 return 92 return
93 } 93 }
94 94
95 // FilterMC installs a counter Memcache filter in the context. 95 // FilterMC installs a counter mc filter in the context.
96 func FilterMC(c context.Context, defaultError error) (context.Context, FeatureBr eaker) { 96 func FilterMC(c context.Context, defaultError error) (context.Context, FeatureBr eaker) {
97 state := newState(defaultError) 97 state := newState(defaultError)
98 » return gae.AddMCFilters(c, func(ic context.Context, rds gae.Memcache) ga e.Memcache { 98 » return mc.AddFilters(c, func(ic context.Context, rds mc.Interface) mc.In terface {
99 return &mcState{state, rds} 99 return &mcState{state, rds}
100 }), state 100 }), state
101 } 101 }
OLDNEW
« no previous file with comments | « filters/featureBreaker/gi.go ('k') | filters/featureBreaker/rds.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698