Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1242973003: Reland "components: Fix 'gn check' errors for omnibox." (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "components: Fix 'gn check' errors for omnibox." This reverts commit cc83d2d66b34ea56edba30cd90538fc1a3343e4f. Tested on Linux with the following command lines: $ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' $ gn check out-gn/Release //components/omnibox/* BUG=367595, 376000 TEST=see above R=brettw@chromium.org Committed: https://crrev.com/c312b420fa49acded38e4bbc00f0f822e4427147 Cr-Commit-Position: refs/heads/master@{#339700}

Patch Set 1 #

Patch Set 2 : public_deps fixes it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M .gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 4 chunks +9 lines, -0 lines 0 comments Download
M components/sessions/BUILD.gn View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
Hi Brett, could you review this to me?
5 years, 5 months ago (2015-07-20 23:56:34 UTC) #2
brettw
lgtm
5 years, 5 months ago (2015-07-21 16:29:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242973003/20001
5 years, 5 months ago (2015-07-21 18:11:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 18:17:58 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 18:19:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c312b420fa49acded38e4bbc00f0f822e4427147
Cr-Commit-Position: refs/heads/master@{#339700}

Powered by Google App Engine
This is Rietveld 408576698