Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: components/sessions/BUILD.gn

Issue 1242973003: Reland "components: Fix 'gn check' errors for omnibox." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: public_deps fixes it Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/omnibox/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 config("implementation") { 9 config("implementation") {
10 defines = [ "SESSIONS_IMPLEMENTATION" ] 10 defines = [ "SESSIONS_IMPLEMENTATION" ]
11 } 11 }
12 12
13 if (!is_ios) { 13 if (!is_ios) {
14 # GYP version: components/sessions.gypi:sessions_content 14 # GYP version: components/sessions.gypi:sessions_content
15 component("sessions") { 15 component("sessions") {
16 sources = [ 16 sources = [
17 "content/content_serialized_navigation_builder.cc", 17 "content/content_serialized_navigation_builder.cc",
18 "content/content_serialized_navigation_builder.h", 18 "content/content_serialized_navigation_builder.h",
19 "content/content_serialized_navigation_driver.cc", 19 "content/content_serialized_navigation_driver.cc",
20 "content/content_serialized_navigation_driver.h", 20 "content/content_serialized_navigation_driver.h",
21 ] 21 ]
22 22
23 configs += [ ":implementation" ] 23 configs += [ ":implementation" ]
24 24
25 public_deps = [
26 ":shared",
27 ]
28
25 deps = [ 29 deps = [
26 ":shared", 30 ":shared",
27 "//base", 31 "//base",
28 "//base/third_party/dynamic_annotations", 32 "//base/third_party/dynamic_annotations",
29 "//content/public/browser", 33 "//content/public/browser",
30 "//ui/base", 34 "//ui/base",
31 "//url", 35 "//url",
32 ] 36 ]
33 } 37 }
34 } else { 38 } else {
35 source_set("sessions") { 39 source_set("sessions") {
36 sources = [ 40 sources = [
37 "ios/ios_serialized_navigation_builder.cc", 41 "ios/ios_serialized_navigation_builder.cc",
38 "ios/ios_serialized_navigation_builder.h", 42 "ios/ios_serialized_navigation_builder.h",
39 "ios/ios_serialized_navigation_driver.cc", 43 "ios/ios_serialized_navigation_driver.cc",
40 "ios/ios_serialized_navigation_driver.h", 44 "ios/ios_serialized_navigation_driver.h",
41 ] 45 ]
42 46
47 public_deps = [
48 ":shared",
49 ]
50
43 deps = [ 51 deps = [
44 ":shared", 52 ":shared",
45 "//base", 53 "//base",
46 54
47 # '../ios/web/ios_web.gyp:ios_web', TODO(GYP) iOS. 55 # '../ios/web/ios_web.gyp:ios_web', TODO(GYP) iOS.
48 ] 56 ]
49 } 57 }
50 } 58 }
51 59
52 # Sources shared between the content and iOS implementations. 60 # Sources shared between the content and iOS implementations.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 "session_types_unittest.cc", 128 "session_types_unittest.cc",
121 ] 129 ]
122 deps = [ 130 deps = [
123 ":sessions", 131 ":sessions",
124 "//base/test:test_support", 132 "//base/test:test_support",
125 "//testing/gtest", 133 "//testing/gtest",
126 "//third_party/protobuf:protobuf_lite", 134 "//third_party/protobuf:protobuf_lite",
127 ] 135 ]
128 } 136 }
129 } 137 }
OLDNEW
« no previous file with comments | « components/omnibox/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698