Reenable overlay scrollbars

Reenable overlay scrollbars

BUG=326635
TEST=Existing
R=jdduke

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243194

[DaveMoore, 2014-01-03 22:58:42]

Take out accidental inclusion of gyp change

[DaveMoore, 2014-01-03 23:00:06]

I'd like to reenable overlay scrollbars (when the flag is passed).

@jdduke had a comment in
https://code.google.com/p/chromium/issues/detail?id=326635 saying that it would
be safe once a patch was landed.

[jdduke (slow), 2014-01-03 23:32:37]

On 2014/01/03 23:00:06, DaveMoore wrote:
> I'd like to reenable overlay scrollbars (when the flag is passed).
> 
> @jdduke had a comment in
> https://code.google.com/p/chromium/issues/detail?id=326635 saying that it
would
> be safe once a patch was landed.

*Might* be safe.  There's no way to know for sure, as we were never able to
repro the crash.

If we re-enable for M34 we'll want to keep a close eye on the dev/canary release
channels.  Also, could you set BUG=326635 so we can keep track of this change?
Thanks.

[DaveMoore, 2014-01-06 16:49:04]

Added Bug #. I'll keep an eye on the crashes in M34.

[jdduke (slow), 2014-01-06 17:10:49]

lgtm

[tony, 2014-01-06 18:05:11]

LGTM2, but I'm also skeptical that jdduke's patch will fix the crash.  I would
consider adding some CHECK's or something to see if we can get more information
from Canary/Dev users.

[jdduke (slow), 2014-01-06 18:20:11]

On 2014/01/06 18:05:11, tony wrote:
> LGTM2, but I'm also skeptical that jdduke's patch will fix the crash.  I would
> consider adding some CHECK's or something to see if we can get more
information
> from Canary/Dev users.

Agreed, I don't think my patch would have fixed whatever issue there was before.

At the least perhaps a CHECK(input_handler_) prior to the MouseMoveAt call. 
However, I'm thinking the issue may have been deeper within
cc::LayerTreeHostImpl::MouseMoveAt, so perhaps a few more vigorous assertions
there?

[DaveMoore, 2014-01-06 18:20:15]

Add CHECK() call

[commit-bot: I haz the power, 2014-01-06 18:22:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/124283003/110001

[commit-bot: I haz the power, 2014-01-06 23:07:44]

Change committed as 243194